[cmd/opampsupervisor] Enable Strict Unmarshal for Supervisor Configuration#36148
Merged
Conversation
…efault provided by koanf Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
akstron
requested review from
a team,
atoulme,
evan-bradley and
tigrannajaryan
as code owners
akstron
changed the title
Contributor
Author
|
Hi @evan-bradley / @atoulme / @tigrannajaryan can you please help review this? Thanks |
Contributor
|
Please add a changelog - any chance you can have a test checking the behavior? |
Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
Contributor
Author
|
Hi @atoulme , added both chlog and test in recent commits. Thanks |
Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
Contributor
Author
|
Hi @atoulme , just following up on this PR. Let me know if there are any concerns or updates? Thanks |
Contributor
fatsheep9146
left a comment
fatsheep9146
left a comment
There was a problem hiding this comment.
Please fix the failed CI lint https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11762947657/job/33410954056?pr=36148
--- a/cmd/opampsupervisor/go.mod
+++ b/cmd/opampsupervisor/go.mod
@@ -4,6 +4,7 @@ go 1.22.0
require (
github.com/cenkalti/backoff/v4 v4.3.0
+ github.com/go-viper/mapstructure/v2 v2.0.0-alpha.1
github.com/google/uuid v1.6.0
github.com/knadh/koanf/maps v0.1.1
github.com/knadh/koanf/parsers/yaml v0.1.0
@@ -25,7 +26,6 @@ require (
require (
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
github.com/fsnotify/fsnotify v1.8.0 // indirect
- github.com/go-viper/mapstructure/v2 v2.0.0-alpha.1 // indirect
github.com/google/go-cmp v0.6.0 // indirect
github.com/gorilla/websocket v1.5.1 // indirect
github.com/mitchellh/copystructure v1.2.0 // indirect
go.mod/go.sum deps changes detected, please run "make gotidy" and commit the changes in this PR.
Contributor
Author
Done, as instructed in the result. |
Contributor
fatsheep9146
left a comment
fatsheep9146
left a comment
There was a problem hiding this comment.
please help resolve the conflict
akstron
force-pushed
the
strict-unmarshal
branch
from
74b8637 to
ed0fa73
Compare
Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
Contributor
Author
Resolved the conflict. Thanks |
Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
Contributor
Author
|
Hi @fatsheep9146 , I fixed the pr check failure. Can you please re-trigger the checks? |
fatsheep9146
approved these changes
Nov 25, 2024
Contributor
|
Ping @atoulme @evan-bradley for a final review. |
evan-bradley
approved these changes
Nov 25, 2024
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
fatsheep9146
added
the
ready to merge
shivanthzen
pushed a commit
to shivanthzen/opentelemetry-collector-contrib
that referenced
this pull request
Dec 5, 2024
…ation (open-telemetry#36148) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The changes includes providing a custom `DecoderConfig` with `ErrorUnused` enabled instead of using the default `DecoderConfig` provided by `koanf` <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes: open-telemetry#35838 <!--Describe what testing was performed and which tests were added.--> <!--Describe the documentation added.--> <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com> Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
ZenoCC-Peng
pushed a commit
to ZenoCC-Peng/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2024
…ation (open-telemetry#36148) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The changes includes providing a custom `DecoderConfig` with `ErrorUnused` enabled instead of using the default `DecoderConfig` provided by `koanf` <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes: open-telemetry#35838 <!--Describe what testing was performed and which tests were added.--> <!--Describe the documentation added.--> <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com> Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…ation (open-telemetry#36148) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The changes includes providing a custom `DecoderConfig` with `ErrorUnused` enabled instead of using the default `DecoderConfig` provided by `koanf` <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes: open-telemetry#35838 <!--Describe what testing was performed and which tests were added.--> <!--Describe the documentation added.--> <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com> Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
…ation (open-telemetry#36148) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The changes includes providing a custom `DecoderConfig` with `ErrorUnused` enabled instead of using the default `DecoderConfig` provided by `koanf` <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes: open-telemetry#35838 <!--Describe what testing was performed and which tests were added.--> <!--Describe the documentation added.--> <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com> Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
…ation (open-telemetry#36148) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The changes includes providing a custom `DecoderConfig` with `ErrorUnused` enabled instead of using the default `DecoderConfig` provided by `koanf` <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes: open-telemetry#35838 <!--Describe what testing was performed and which tests were added.--> <!--Describe the documentation added.--> <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com> Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
zeck-ops
pushed a commit
to zeck-ops/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
…ation (open-telemetry#36148) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The changes includes providing a custom `DecoderConfig` with `ErrorUnused` enabled instead of using the default `DecoderConfig` provided by `koanf` <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes: open-telemetry#35838 <!--Describe what testing was performed and which tests were added.--> <!--Describe the documentation added.--> <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com> Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The changes includes providing a custom
DecoderConfigwithErrorUnusedenabled instead of using the defaultDecoderConfigprovided bykoanfLink to tracking issue
Fixes: #35838