[connector/spanmetrics] CHANGELOG is fixed to reflect the correct fea…#35852
Merged
Conversation
|
|
songy23
reviewed
Oct 23, 2024
Member
songy23
left a comment
songy23
left a comment
There was a problem hiding this comment.
PR looks good, please sign the CLA @tbeemster
songy23
added
documentation
Contributor
Author
|
I've just signed the CLA and rebased |
Member
|
Looks like your commit has 2 authors @timbeemster @tbeemster and both need to sign CLA or you can create a new PR with commit only from @tbeemster |
…ture gate The wrong feature gate was exposed in the CHANGELOG, this has been corrected to the correct feature gate 'connector.spanmetrics.legacyMetricNames'
Contributor
Author
|
Hi @songy23 , sorry for the late response. Best regards, Tim |
MovieStoreGuy
approved these changes
Nov 10, 2024
pull Bot
pushed a commit
to abaguas/opentelemetry-collector-contrib
that referenced
this pull request
Nov 11, 2024
open-telemetry#35852) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The wrong feature gate was exposed in the CHANGELOG, this has been corrected to the correct feature gate 'connector.spanmetrics.legacyMetricNames' <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#35766 <!--Describe the documentation added.--> #### Documentation CHANGELOG.md is updated to have the correct feature gate name. <!--Please delete paragraphs that you did not use before submitting.-->
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
open-telemetry#35852) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The wrong feature gate was exposed in the CHANGELOG, this has been corrected to the correct feature gate 'connector.spanmetrics.legacyMetricNames' <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#35766 <!--Describe the documentation added.--> #### Documentation CHANGELOG.md is updated to have the correct feature gate name. <!--Please delete paragraphs that you did not use before submitting.-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The wrong feature gate was exposed in the CHANGELOG, this has been corrected to the correct feature gate 'connector.spanmetrics.legacyMetricNames'
Link to tracking issue
Fixes #35766
Documentation
CHANGELOG.md is updated to have the correct feature gate name.