Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric-specific labels in googlecloudmonitoringreceiver component #35828

Conversation

abhishek-at-cloudwerx
Copy link
Contributor

@abhishek-at-cloudwerx abhishek-at-cloudwerx commented Oct 16, 2024

Description

Add metric-specific labels inside the googlecloudmonitoringreceiver component

Link to tracking issue

#35711

Testing

Documentation

- Add metric-specific labels inside the googlecloudmonitoringreceiver component
- Add .chloggen file
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add unit tests

receiver/googlecloudmonitoringreceiver/receiver.go Outdated Show resolved Hide resolved
- Update functions to handle nil values
@abhishek-at-cloudwerx
Copy link
Contributor Author

please add unit tests

Will create separate PR for it

@dashpole
Copy link
Contributor

Will create separate PR for it

Please add it to this PR. Code and tests should be submitted together.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 1, 2024
@dashpole dashpole removed the Stale label Nov 1, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 16, 2024
@dashpole dashpole removed the Stale label Nov 18, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 3, 2024
@dashpole dashpole removed the Stale label Dec 3, 2024
@dashpole
Copy link
Contributor

I've been promised that tests are coming in a separate PR.

@dashpole dashpole added ready to merge Code review completed; ready to merge by maintainers bug Something isn't working labels Dec 12, 2024
@andrzej-stencel andrzej-stencel merged commit 5eb2a16 into open-telemetry:main Dec 16, 2024
179 of 180 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 16, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…open-telemetry#35828)

#### Description
Add metric-specific labels inside the googlecloudmonitoringreceiver
component

#### Link to tracking issue

open-telemetry#35711

#### Testing

#### Documentation
mterhar pushed a commit to mterhar/opentelemetry-collector-contrib that referenced this pull request Dec 19, 2024
…open-telemetry#35828)

#### Description
Add metric-specific labels inside the googlecloudmonitoringreceiver
component

#### Link to tracking issue

open-telemetry#35711

#### Testing

#### Documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready to merge Code review completed; ready to merge by maintainers receiver/googlecloudmonitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants