Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix Supervisor tests on Windows #35818

Merged

Conversation

evan-bradley
Copy link
Contributor

Description

This fixes a few tests on Windows that were failing due to a mismatch between newline character sequences between Windows and non-Windows operating systems.

Link to tracking issue

Fixes #35812

@evan-bradley evan-bradley added the Run Windows Enable running windows test on a PR label Oct 15, 2024
@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Oct 15, 2024
@dmitryax dmitryax merged commit 3ae160f into open-telemetry:main Oct 15, 2024
200 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 15, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
#### Description

This fixes a few tests on Windows that were failing due to a mismatch
between newline character sequences between Windows and non-Windows
operating systems.

#### Link to tracking issue
Fixes
open-telemetry#35812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/opampsupervisor ready to merge Code review completed; ready to merge by maintainers Run Windows Enable running windows test on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test] TestSupervisor_setupOwnMetrics is broken on Windows CI
3 participants