[chore] Reference documentation.md for resource attributes per resource detector#35737
Merged
Merged
Conversation
…ce detector Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
github-actions
Bot
added
the
processor/resourcedetection
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Member
Author
|
/cc @open-telemetry/collector-contrib-approvers |
mx-psi
approved these changes
Oct 30, 2024
zzhlogin
pushed a commit
to zzhlogin/opentelemetry-collector-contrib-aws
that referenced
this pull request
Nov 12, 2024
…ce detector (open-telemetry#35737) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR fixes the issue described at open-telemetry#34210. Each detector's docs should list the resource attributes as they are defined by the `metadata.yml` files. This PR links each detector to its `documentation.md` as a reference for the respective Resource Atrributes. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#34210 <!--Describe what testing was performed and which tests were added.--> #### Testing ~ <!--Describe the documentation added.--> #### Documentation Added <!--Please delete paragraphs that you did not use before submitting.--> Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…ce detector (open-telemetry#35737) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR fixes the issue described at open-telemetry#34210. Each detector's docs should list the resource attributes as they are defined by the `metadata.yml` files. This PR links each detector to its `documentation.md` as a reference for the respective Resource Atrributes. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#34210 <!--Describe what testing was performed and which tests were added.--> #### Testing ~ <!--Describe the documentation added.--> #### Documentation Added <!--Please delete paragraphs that you did not use before submitting.--> Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue described at #34210.
Each detector's docs should list the resource attributes as they are defined by the
metadata.ymlfiles.This PR links each detector to its
documentation.mdas a reference for the respective Resource Atrributes.Link to tracking issue
Fixes #34210
Testing ~
Documentation
Added