feat: added prometheus rw2 translation for gauges#35734
Merged
andrzej-stencel merged 8 commits intoOct 16, 2024
Merged
Conversation
Signed-off-by: Juraj Michalek <juraj.michalek132@gmail.com>
ArthurSens
reviewed
Oct 10, 2024
Member
ArthurSens
left a comment
ArthurSens
left a comment
There was a problem hiding this comment.
Nice work!
The PR is basically ready for merge to be honest, I just have a few questions and comments around tests
…t.go Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Juraj Michalek <juraj.michalek132@gmail.com>
dashpole
approved these changes
Oct 11, 2024
Contributor
dashpole
left a comment
dashpole
left a comment
There was a problem hiding this comment.
lgtm after outstanding comment is resolved
Signed-off-by: Juraj Michalek <juraj.michalek132@gmail.com>
dashpole
approved these changes
Oct 11, 2024
dashpole
added
the
ready to merge
jmichalek132
changed the title
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Follow up from open-telemetry#35703. Draft starting the work on adding support for remote write 2.0 in the translation package. Adding support for translating gauges. This is first iteration and to keep the PR small * we don't handle duplicate metrics * only support gauges * don't handle other labels than metric name * don't handle exemplars * don't handle metadata <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue open-telemetry#33661 Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Juraj Michalek <juraj.michalek132@gmail.com> Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com> Co-authored-by: David Ashpole <dashpole@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up from #35703.
Draft starting the work on adding support for remote write 2.0 in the translation package.
Adding support for translating gauges.
This is first iteration and to keep the PR small
Link to tracking issue #33661
Fixes
Testing
Documentation