Skip to content

[extension/sumologic] Add new products to auto discovery#35622

Merged
andrzej-stencel merged 1 commit into
open-telemetry:mainfrom
chan-tim-sumo:chan-tim_autodiscovery
Nov 20, 2024
Merged

[extension/sumologic] Add new products to auto discovery#35622
andrzej-stencel merged 1 commit into
open-telemetry:mainfrom
chan-tim-sumo:chan-tim_autodiscovery

Conversation

@chan-tim-sumo
Copy link
Copy Markdown
Contributor

@chan-tim-sumo chan-tim-sumo commented Oct 4, 2024

Description

  • Added new products to auto discovery for the otel collector to detect the new processes running in the background.
[x] jmx
[x] activemq
[x] docker ce
[x] haproxy
[x] memcached
[x] mongodb
[x] cassandra
[x] microsoft sql server (linux)
[] oracledb (not including in this iteration)

Link to tracking issue

Testing

  • ran in staging/long env
  • Screenshots of the products showing up in COLLECTOR TAGS is in the jira.

Documentation

Copy link
Copy Markdown
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the merge conflicts

Does this need a changelog?

@github-actions
Copy link
Copy Markdown
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions Bot added the Stale label Oct 19, 2024
@chan-tim-sumo chan-tim-sumo force-pushed the chan-tim_autodiscovery branch 4 times, most recently from 07d0125 to 0801b46 Compare October 23, 2024 23:36
@chan-tim-sumo chan-tim-sumo requested a review from songy23 November 1, 2024 21:21
@chan-tim-sumo
Copy link
Copy Markdown
Contributor Author

@fatsheep9146 can you take a look at this PR as well?

@atoulme
Copy link
Copy Markdown
Contributor

atoulme commented Nov 12, 2024

Please resolve conflicts.

Given that this is specifically related to the sumologic extension, it would be great to get the codeowner's review - @rnishtala-sumo please review.

Copy link
Copy Markdown
Contributor

@fguimond fguimond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread extension/sumologicextension/extension.go
@andrzej-stencel andrzej-stencel changed the title Added new products to auto discovery for sumo otel collector [exporter/sumologic] Add new products to auto discovery Nov 20, 2024
@andrzej-stencel andrzej-stencel changed the title [exporter/sumologic] Add new products to auto discovery [extension/sumologic] Add new products to auto discovery Nov 20, 2024
Copy link
Copy Markdown
Contributor

@rnishtala-sumo rnishtala-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrzej-stencel andrzej-stencel merged commit 909c107 into open-telemetry:main Nov 20, 2024
@github-actions github-actions Bot added this to the next release milestone Nov 20, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…try#35622)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
- Added new products to auto discovery for the otel collector to detect
the new processes running in the background.
```
[x] jmx
[x] activemq
[x] docker ce
[x] haproxy
[x] memcached
[x] mongodb
[x] cassandra
[x] microsoft sql server (linux)
[] oracledb (not including in this iteration)
```

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
- https://sumologic.atlassian.net/browse/OSC-838

<!--Describe what testing was performed and which tests were added.-->
#### Testing
- ran in staging/long env
- Screenshots of the products showing up in COLLECTOR TAGS is in the
jira.

<!--Describe the documentation added.-->
#### Documentation
-
https://help.sumologic.com/docs/send-data/opentelemetry-collector/auto-discovery/#view-discovered-services

<!--Please delete paragraphs that you did not use before submitting.-->
AkhigbeEromo pushed a commit to sematext/opentelemetry-collector-contrib that referenced this pull request Jan 13, 2025
…try#35622)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
- Added new products to auto discovery for the otel collector to detect
the new processes running in the background.
```
[x] jmx
[x] activemq
[x] docker ce
[x] haproxy
[x] memcached
[x] mongodb
[x] cassandra
[x] microsoft sql server (linux)
[] oracledb (not including in this iteration)
```

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
- https://sumologic.atlassian.net/browse/OSC-838

<!--Describe what testing was performed and which tests were added.-->
#### Testing
- ran in staging/long env
- Screenshots of the products showing up in COLLECTOR TAGS is in the
jira.

<!--Describe the documentation added.-->
#### Documentation
-
https://help.sumologic.com/docs/send-data/opentelemetry-collector/auto-discovery/#view-discovered-services

<!--Please delete paragraphs that you did not use before submitting.-->
zeck-ops pushed a commit to zeck-ops/opentelemetry-collector-contrib that referenced this pull request Apr 23, 2025
…try#35622)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
- Added new products to auto discovery for the otel collector to detect
the new processes running in the background.
```
[x] jmx
[x] activemq
[x] docker ce
[x] haproxy
[x] memcached
[x] mongodb
[x] cassandra
[x] microsoft sql server (linux)
[] oracledb (not including in this iteration)
```

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
- https://sumologic.atlassian.net/browse/OSC-838

<!--Describe what testing was performed and which tests were added.-->
#### Testing
- ran in staging/long env
- Screenshots of the products showing up in COLLECTOR TAGS is in the
jira.

<!--Describe the documentation added.-->
#### Documentation
-
https://help.sumologic.com/docs/send-data/opentelemetry-collector/auto-discovery/#view-discovered-services

<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants