[exporter/clickhouse] use observed timestamp in logs #34151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanjm
approved these changes
Jul 18, 2024
SpencerTorres
approved these changes
Jul 19, 2024
pimeys
force-pushed
the
use-observed-timestamp-if-timestamp-is-missing
branch
2 times, most recently
from
d1872aa to
434e0b4
Compare
|
I added the changelog and amended. Should be good now. |
pimeys
force-pushed
the
use-observed-timestamp-if-timestamp-is-missing
branch
2 times, most recently
from
d716293 to
ca2f6bb
Compare
…missing Some senders, such as the rust-opentelemetry do _not_ send timestamp in their logs. In these cases, if the timestamp is not set, we must use the observed timestamp instead.
pimeys
force-pushed
the
use-observed-timestamp-if-timestamp-is-missing
branch
from
ca2f6bb to
56cceb8
Compare
crobert-1
reviewed
Jul 29, 2024
|
@pimeys looks like there's a couple nits to the changelog. Let me know if you can resolve those so we can get this merged 👍 |
crobert-1
approved these changes
Jul 31, 2024
crobert-1
added
the
ready to merge
Frapschen
approved these changes
Aug 7, 2024
codeboten
approved these changes
Aug 7, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…34151) **Description:** Some senders, such as the rust-opentelemetry do _not_ send timestamp in their logs. In these cases, if the timestamp is not set, we must use the observed timestamp instead. **Link to tracking Issue:** open-telemetry#34150 **Testing:** Added a test which does not define timestamp --------- Co-authored-by: Curtis Robert <[email protected]> Co-authored-by: Pablo Baeyens <[email protected]> Co-authored-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Some senders, such as the rust-opentelemetry do not send timestamp in their logs. In these cases, if the timestamp is not set, we must use the observed timestamp instead.
Link to tracking Issue: #34150
Testing: Added a test which does not define timestamp