-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/kubeletstats] Add k8s.{container,pod}.memory.node.utilization
metrics
#33591
[receiver/kubeletstats] Add k8s.{container,pod}.memory.node.utilization
metrics
#33591
Conversation
e2caba0
to
df81840
Compare
I missed why did we go with the dots instead of |
A valid alternative would be Based on this, instead of |
b5f9c5b
to
5ae764d
Compare
…on metrics Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
5ae764d
to
2b853bd
Compare
@TylerHelmuth @dmitryax Anything else missing here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also see this discussion in similar PR: There, the metric name evolved from |
Description:
Similar to #32295 and #33390, this PR adds the
k8s.{container,pod}.memory.node.utilization
metrics.Link to tracking Issue: #27885
Testing: Added unit test.
Documentation: Added
Manual testing
On a node of 32,5G memory the 800Mb container/Pod consumes the
0.8/32.5=0.0246...=0.025
.