[receiver/podman] remove config Validate call on start #33555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skip changelog? Collectors user should not be affected |
crobert-1
approved these changes
Jun 13, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
andrzej-stencel
approved these changes
Jul 8, 2024
crobert-1
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Configuration validation is done during collector's startup, making it redundant when being called inside component's logic. This PR removes the Validate call done during Podman's receiver start function.
Link to tracking Issue:
#33498
Context: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/32981/files#r1621849257
Testing:
Tests moved to the
config_test.gofile following the testdata strategy.Documentation: