Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [k8s] fix k8s e2e tests #33548

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Jun 13, 2024

Description:

Only return address that is not empty for kind network.
This started affecting the e2e tests possibly because of the ubuntu-latest's docker version update that is mentioned at #33520 (comment).
Relates to #33520.

/cc @fatsheep9146

Sample kind network:

curl --unix-socket /run/docker.sock http://docker/networks/kind | jq              
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   841  100   841    0     0   821k      0 --:--:-- --:--:-- --:--:--  821k
{
  "Name": "kind",
  "Id": "801d2abe204253cbd5d1d135f111a7fb386b830382bde79a699fb4f9aaf674b1",
  "Created": "2024-06-13T15:31:57.738509232+03:00",
  "Scope": "local",
  "Driver": "bridge",
  "EnableIPv6": true,
  "IPAM": {
    "Driver": "default",
    "Options": {},
    "Config": [
      {
        "Subnet": "fc00:f853:ccd:e793::/64"
      },
      {
        "Subnet": "172.18.0.0/16",
        "Gateway": "172.18.0.1"
      }
    ]
  },
  "Internal": false,
  "Attachable": false,
  "Ingress": false,
  "ConfigFrom": {
    "Network": ""
  },
  "ConfigOnly": false,
  "Containers": {
    "db113750635782bc1bfdf31e5f62af3c63f02a9c8844f7fe9ef045b5d9b76d12": {
      "Name": "kind-control-plane",
      "EndpointID": "8b15bb391109ca1ecfbb4bf7a96060b01e3913694d34e23d67eec22684f037bb",
      "MacAddress": "02:42:ac:12:00:02",
      "IPv4Address": "172.18.0.2/16",
      "IPv6Address": "fc00:f853:ccd:e793::2/64"
    }
  },
  "Options": {
    "com.docker.network.bridge.enable_ip_masquerade": "true",
    "com.docker.network.driver.mtu": "1500"
  },
  "Labels": {}
}

Link to tracking Issue:

Testing:

Documentation:

Signed-off-by: ChrsMark <[email protected]>
@ChrsMark ChrsMark changed the title [k8s] fix k8s e2e tests [chore] [k8s] fix k8s e2e tests Jun 13, 2024
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark ChrsMark marked this pull request as ready for review June 13, 2024 15:45
@ChrsMark ChrsMark requested a review from a team June 13, 2024 15:45
@TylerHelmuth TylerHelmuth merged commit 7519485 into open-telemetry:main Jun 13, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 13, 2024
@crobert-1 crobert-1 mentioned this pull request Jun 13, 2024
joaopgrassi added a commit to Dynatrace/dynatrace-otel-collector that referenced this pull request Jun 24, 2024
joaopgrassi added a commit to Dynatrace/dynatrace-otel-collector that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants