Skip to content

Support injecting headers #33517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

samiura
Copy link
Contributor

@samiura samiura commented Jun 12, 2024

Description: Injecting headers
Link to tracking Issue:#33260

Testing: Tested locally using Kafka -> Kafka receiver -> otel-collector -> kafka exporter

Documentation:

@samiura samiura requested a review from MovieStoreGuy as a code owner June 12, 2024 19:26
@samiura samiura requested a review from a team June 12, 2024 19:26
@github-actions github-actions bot requested a review from pavolloffay June 12, 2024 19:26
@samiura
Copy link
Contributor Author

samiura commented Jun 12, 2024

I am looking at the e2e k8s test failures

@crobert-1
Copy link
Member

I am looking at the e2e k8s test failures

There appears to be some flakiness on main today with the e2e-tests action, I don't believe those failures are related to this PR.

@samiura samiura force-pushed the branch-issue-33260 branch from 503599b to a1bd26b Compare June 13, 2024 14:34
Copy link
Contributor

@MovieStoreGuy MovieStoreGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only adds it into the configuration, is there work to apply it to the client?

// Whether to inject headers or not, default is false.
InjectHeaders bool `mapstructure:"inject_headers"`

// list of header complaint with kafka receiver
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the compliant headers? How does a user know which headers are compliant?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// list of header complaint with kafka receiver
// headers to inject in kafka messages

Copy link
Contributor

github-actions bot commented Jul 5, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 5, 2024
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jul 20, 2024
@atoulme atoulme reopened this Oct 2, 2024
@atoulme atoulme requested a review from a team as a code owner October 2, 2024 05:25
@atoulme atoulme requested a review from crobert-1 October 2, 2024 05:25
@@ -64,6 +67,14 @@ type Config struct {
Authentication kafka.Authentication `mapstructure:"auth"`
}

type HeaderInjection struct {
// Whether to inject headers or not, default is false.
InjectHeaders bool `mapstructure:"inject_headers"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this boolean needed? You might not need that, just check any headers are present.

InjectHeaders bool `mapstructure:"inject_headers"`

// list of header complaint with kafka receiver
Headers []string `mapstructure:"headers"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add code to set the headers.

@github-actions github-actions bot removed the Stale label Oct 3, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 18, 2024
Copy link
Contributor

github-actions bot commented Nov 2, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants