-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Support injecting headers #33517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support injecting headers #33517
Conversation
I am looking at the e2e k8s test failures |
There appears to be some flakiness on |
503599b
to
a1bd26b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only adds it into the configuration, is there work to apply it to the client?
// Whether to inject headers or not, default is false. | ||
InjectHeaders bool `mapstructure:"inject_headers"` | ||
|
||
// list of header complaint with kafka receiver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the compliant headers? How does a user know which headers are compliant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// list of header complaint with kafka receiver | |
// headers to inject in kafka messages |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
@@ -64,6 +67,14 @@ type Config struct { | |||
Authentication kafka.Authentication `mapstructure:"auth"` | |||
} | |||
|
|||
type HeaderInjection struct { | |||
// Whether to inject headers or not, default is false. | |||
InjectHeaders bool `mapstructure:"inject_headers"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this boolean needed? You might not need that, just check any headers are present.
InjectHeaders bool `mapstructure:"inject_headers"` | ||
|
||
// list of header complaint with kafka receiver | ||
Headers []string `mapstructure:"headers"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add code to set the headers.
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description: Injecting headers
Link to tracking Issue:#33260
Testing: Tested locally using Kafka -> Kafka receiver -> otel-collector -> kafka exporter
Documentation: