Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/deltatocumulative]: fix TestLimitEvict #33266

Merged
merged 3 commits into from
May 31, 2024

Conversation

sh0rez
Copy link
Member

@sh0rez sh0rez commented May 28, 2024

Description: due to undefined map iteration order, this test was flaky

Fixes #33094

@sh0rez sh0rez requested a review from jpkrohling as a code owner May 28, 2024 16:34
@sh0rez sh0rez requested a review from a team May 28, 2024 16:34
@sh0rez
Copy link
Member Author

sh0rez commented May 28, 2024

needs no changelog imo, please add the label

@github-actions github-actions bot requested a review from RichieSams May 28, 2024 16:35
@crobert-1 crobert-1 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 28, 2024
@crobert-1
Copy link
Member

Hello @sh0rez, can you update your description to allow GitHub to automatically close the issue?

@crobert-1 crobert-1 added the ready to merge Code review completed; ready to merge by maintainers label May 28, 2024
due to undefined map iteration order, this test was flaky
@sh0rez sh0rez force-pushed the test-limit-flake branch from ff28066 to d525335 Compare May 29, 2024 12:58
@codeboten codeboten merged commit 88eba8f into open-telemetry:main May 31, 2024
162 checks passed
@github-actions github-actions bot added this to the next release milestone May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/deltatocumulative ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[processor/deltatocumulative] TestLimitEvict failure
5 participants