fix(deps): update module github.com/prometheus/prometheus to v0.52.0 #33059
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
added
dependencies
renovate
bot
requested review from
fatsheep9146,
jpkrohling,
Aneurysm9 and
dashpole
as code owners
|
github-actions
bot
added
cmd/otelcontribcol
github-actions
bot
requested review from
bertysentry,
chrroberts-pure,
dgoscn,
gouthamve,
mar4uk and
rapphil
| github.com/distribution/reference v0.5.0 // indirect | ||
| github.com/docker/docker v25.0.5+incompatible // indirect | ||
| github.com/docker/docker v26.0.1+incompatible // indirect |
| github.com/distribution/reference v0.5.0 // indirect | ||
| github.com/docker/docker v25.0.5+incompatible // indirect | ||
| github.com/docker/docker v26.0.1+incompatible // indirect |
There was a problem hiding this comment.
I think this breaks the build? Since failed build lint check show the otelcontribcol is not built successfully.
There was a problem hiding this comment.
The failed build is due to github.com/google/cadvisor
# github.com/google/cadvisor/container/docker/utils
../../../../../pkg/mod/github.com/google/[email protected]/container/docker/utils/docker.go:48:42: undefined: dockertypes.Info
../../../../../pkg/mod/github.com/google/[email protected]/container/docker/utils/docker.go:57:44: undefined: dockertypes.Info
../../../../../pkg/mod/github.com/google/[email protected]/container/docker/utils/docker.go:77:43: undefined: dockertypes.Info
../../../../../pkg/mod/github.com/google/[email protected]/container/docker/utils/docker.go:86:48: undefined: dockertypes.ImageSummary
I try the latest version of cadvisor 0.49.1 again, it stills failed in same reason.
Should this be solved by cadvisor first, then continue this pr? @songy23
There was a problem hiding this comment.
Yes. Problem is cadvisor depends on github.com/docker/docker v24.0.9+incompatible https://github.com/google/cadvisor/blob/master/go.mod#L14 and that version does not work with the one here. Until cadvisor adopts v26.0.1+incompatible this PR cannot move forward.
There was a problem hiding this comment.
Is there a reason they stick on the old version or can we bump it in their project?
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
This PR contains the following updates:
v0.51.2-0.20240405174432-b4a973753c6e->v0.52.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
prometheus/prometheus (github.com/prometheus/prometheus)
v0.52.0Compare Source
v0.52.0-rc.1Compare Source
v0.52.0-rc.0Compare Source
Configuration
📅 Schedule: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.