[chore] [pkg/stanza] Pass telemetry settings by value #32672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrsMark
force-pushed
the
pass_telemetry_by_value
branch
from
73bf890 to
16afd46
Compare
Telemetry settings in general are passed by value in the project. This commit aligns the stanza Builder interface with this convention. This will also ensures that Logger can be overwritten without changing the original object. Signed-off-by: ChrsMark <[email protected]>
ChrsMark
force-pushed
the
pass_telemetry_by_value
branch
from
16afd46 to
821a435
Compare
ChrsMark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Telemetry settings in general are passed by value in the project. This commit aligns the stanza Builder interface with this convention. This will also ensures that Logger can be overwritten without changing the original object.
Follow up of #32662.
cc-ing @djaglowski who pointed that out.
Link to tracking Issue:
Testing: Same as #32662
Documentation: