cmd/telemetrygen: Add headers to gRPC metadata for logs #32668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metalmatze
force-pushed
the
telemetrygen-logs-grpc-metadata
branch
from
f6308ce to
d796638
Compare
|
Rebased against the latest |
metalmatze
force-pushed
the
telemetrygen-logs-grpc-metadata
branch
from
d796638 to
f528611
Compare
songy23
added
Skip Changelog
songy23
approved these changes
Apr 24, 2024
Co-authored-by: Yang Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
So far, sending (HTTP) headers along with gRPC requests hasn't been possible.
For that reason, sending bearer tokens for authentication didn't work either.
This is fixed now.
Updated version of #30082
cc @mx-psi