Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] rollback otelhttp dep #31141

Merged
merged 3 commits into from
Feb 8, 2024
Merged

[chore] rollback otelhttp dep #31141

merged 3 commits into from
Feb 8, 2024

Conversation

codeboten
Copy link
Contributor

v0.48.0 causes data races in the unit tests

[chore] rollback otelhttp dep
aaaabcd 
v0.48.0 causes data races in the unit tests

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten requested a review from a team February 8, 2024 19:25
update gosum file
69d6df8 
Signed-off-by: Alex Boten <[email protected]>
tidy
804d32c 
Signed-off-by: Alex Boten <[email protected]>
@crobert-1
Copy link
Member

crobert-1 commented Feb 8, 2024 •
edited
Loading

Failing opampsupervisor test is frequency of #30931, I've added a reference there.

@crobert-1
Copy link
Member

For reference this is the bug we're rolling back to avoid.

@codeboten codeboten merged commit 2c870ce into open-telemetry:main Feb 8, 2024
151 of 152 checks passed
@codeboten codeboten deleted the codeboten/rollback-otelhttp-dep branch February 8, 2024 20:07
@github-actions github-actions bot added this to the next release milestone Feb 8, 2024
This was referenced Feb 8, 2024
Closed
Closed
@crobert-1
Copy link
Member

Thanks for handling so quickly @codeboten, really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

@yurishkuro yurishkuro Awaiting requested review from yurishkuro yurishkuro is a code owner

@arminru arminru Awaiting requested review from arminru

@evan-bradley evan-bradley Awaiting requested review from evan-bradley

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

Assignees

@atoulme atoulme

Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol cmd/telemetrygen telemetrygen command connector/datadog examples/demo exporter/alertmanager exporter/datadog Datadog components exporter/dynatrace exporter/f5cloud F5 exporter exporter/honeycombmarker exporter/influxdb exporter/instana exporter/logicmonitor exporter/logzio exporter/loki Loki Exporter exporter/mezmo exporter/opensearch exporter/prometheus exporter/prometheusremotewrite exporter/signalfx exporter/splunkhec exporter/sumologic exporter/zipkin extension/healthcheck Health Check Extension extension/httpforwarder extension/jaegerremotesampling extension/oauth2clientauth extension/observer extension/remotetap extension/sumologic internal/aws processor/groupbytrace Group By Trace processor processor/k8sattributes k8s Attributes processor processor/remotetap processor/resourcedetection Resource detection processor processor/schema Schema processor receiver/apache receiver/apachespark receiver/awscontainerinsight receiver/awsecscontainermetrics receiver/awsfirehose receiver/bigip receiver/cloudfoundry receiver/collectd receiver/couchdb receiver/datadog receiver/elasticsearch
Projects
None yet
Milestone
v0.95.0
Development

Successfully merging this pull request may close these issues.
5 participants
@codeboten @crobert-1 @bogdandrutu @songy23 @atoulme