Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Use component.MustNewType everywhere #31072

Merged
merged 2 commits into from
Feb 6, 2024
Merged

[chore] Use component.MustNewType everywhere #31072

merged 2 commits into from
Feb 6, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Feb 6, 2024

Description: Replaces usages of component.Type(..) by component.MustNewType

Link to tracking Issue: Needed for open-telemetry/opentelemetry-collector/pull/9472

@mx-psi mx-psi marked this pull request as ready for review February 6, 2024 12:17
@mx-psi mx-psi requested a review from a team February 6, 2024 12:17
@mx-psi mx-psi merged commit eb6e6f6 into open-telemetry:main Feb 6, 2024
144 checks passed
@mx-psi mx-psi deleted the mx-psi/mustnewtype-in-tests branch February 6, 2024 13:38
@github-actions github-actions bot added this to the next release milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@songy23 songy23 songy23 approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@boostchicken boostchicken Awaiting requested review from boostchicken

@dashpole dashpole Awaiting requested review from dashpole

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@Frapschen Frapschen Awaiting requested review from Frapschen

@hanjm hanjm Awaiting requested review from hanjm

@hvaghani221 hvaghani221 Awaiting requested review from hvaghani221

@jamesmoessis jamesmoessis Awaiting requested review from jamesmoessis

@kasia-kujawa kasia-kujawa Awaiting requested review from kasia-kujawa

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@povilasv povilasv Awaiting requested review from povilasv

@rmfitzpatrick rmfitzpatrick Awaiting requested review from rmfitzpatrick

@rnishtala-sumo rnishtala-sumo Awaiting requested review from rnishtala-sumo

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

Assignees

@dashpole dashpole

Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command exporter/clickhouse exporter/sumologic exporter/syslog extension/httpforwarder extension/storage pkg/stanza processor/cumulativetodelta Cumulative To Delta processor processor/deltatorate Delta To Rate processor processor/filter Filter processor processor/metricsgeneration Metrics Generation processor processor/metricstransform Metrics Transform processor processor/resourcedetection Resource detection processor receiver/azureeventhub receiver/chrony receiver/fluentforward receiver/jmx JMX Receiver receiver/k8scluster receiver/k8sevents receiver/k8sobjects receiver/splunkhec receiver/zookeeper
Projects
None yet
Milestone
v0.94.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mx-psi @songy23 @sumo-drosiek @dashpole