Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Remove unmaintained file receiver #31051

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

djaglowski
Copy link
Member

This component never advanced beyond development status and is incomplete so I propose that it be deleted.

@djaglowski djaglowski marked this pull request as ready for review February 6, 2024 14:23
@djaglowski djaglowski requested review from a team and bryan-aguilar February 6, 2024 14:23
@djaglowski
Copy link
Member Author

Apparently this was added to the contrib distribution despite still being in development status. Consequently I think we should wait to merge this until after the release.

@crobert-1
Copy link
Member

Apparently this was added to the contrib distribution despite still being in development status. Consequently I think we should wait to merge this until after the release.

That's my bad, sorry about that!

@djaglowski djaglowski merged commit 3ad413f into open-telemetry:main Feb 8, 2024
155 of 156 checks passed
@djaglowski djaglowski deleted the rm-filereceiver branch February 8, 2024 21:00
@github-actions github-actions bot added this to the next release milestone Feb 8, 2024
@evantorrie
Copy link
Contributor

This probably should have been mentioned in the CHANGELOG for v0.95.0.

@gitck-scch
Copy link

What is required to get this file receiver back again? The file exporter should not be the dead end for supporting a offline scenario. There has to be also a corresponding file receiver beeing able to import the file persisted data again later. Or is there already another solution that supports this?

@djaglowski
Copy link
Member Author

@gitck-scch, I agree it would be nice to have a file receiver with functionality that mirrors the file exporter. The primary reason this component was removed is that it was not fully implemented and no one was willing to work on it.

I would be willing to sponsor a new implementation provided that the contributor is committed to fully implementing functionality which matches the exporter. I also would require that the implementation make use of the fileconsumer package so that we are not writing a redundant mechanism for tracking and reading files.

@gitck-scch
Copy link

@djaglowski, thank you for the fast reponse - I suspected already something like this.
We will take a look at the exporter and fileconsumer in order to be able to estimate the effort required for a corresponding implementation - get back to you later.
Of course, I would also appreciate direct links to corresponding issues describing the requirements, if available.

@atoulme
Copy link
Contributor

atoulme commented Mar 19, 2024

@gitck-scch
Copy link

@atoulme, is this receiver capable to import files written with the file exporter (is compression (zstd) supported)? Does this receiver fulfill a different purpose in contrast to the discontinued file receiver?

@atoulme
Copy link
Contributor

atoulme commented Mar 20, 2024

I don't know off the top of my head, you can check for yourself here: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/otlpjsonfilereceiver (ok, I checked, no, it doesn't look like we do).

The file receiver was never completed as far as I know, so there's no real comparison to draw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants