-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Remove unmaintained file receiver #31051
Conversation
8884edc
to
f6ef6e0
Compare
f6ef6e0
to
760bbbe
Compare
760bbbe
to
b8851e1
Compare
Apparently this was added to the contrib distribution despite still being in development status. Consequently I think we should wait to merge this until after the release. |
That's my bad, sorry about that! |
b8851e1
to
656f2fe
Compare
This probably should have been mentioned in the CHANGELOG for v0.95.0. |
What is required to get this file receiver back again? The file exporter should not be the dead end for supporting a offline scenario. There has to be also a corresponding file receiver beeing able to import the file persisted data again later. Or is there already another solution that supports this? |
@gitck-scch, I agree it would be nice to have a file receiver with functionality that mirrors the file exporter. The primary reason this component was removed is that it was not fully implemented and no one was willing to work on it. I would be willing to sponsor a new implementation provided that the contributor is committed to fully implementing functionality which matches the exporter. I also would require that the implementation make use of the fileconsumer package so that we are not writing a redundant mechanism for tracking and reading files. |
@djaglowski, thank you for the fast reponse - I suspected already something like this. |
This receiver works fine: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/otlpjsonfilereceiver - feel free to make it better |
@atoulme, is this receiver capable to import files written with the file exporter (is compression (zstd) supported)? Does this receiver fulfill a different purpose in contrast to the discontinued file receiver? |
I don't know off the top of my head, you can check for yourself here: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/otlpjsonfilereceiver (ok, I checked, no, it doesn't look like we do). The file receiver was never completed as far as I know, so there's no real comparison to draw. |
This component never advanced beyond development status and is incomplete so I propose that it be deleted.