Improve logging and metrics for kafka receiver #30256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds-docusign/opentelemetry-collector-contrib into bc--improvekafkareceiverlogging
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds additional information to the existing logs for consumer group startup and adds the topic and partition to the existing instanceName label so that users of the kafka receiver can monitor all of the metrics per topic/partition.
Currently the metrics are all reported with the same tags so each partition clobbers the other partitions data
Link to tracking Issue:
#28631
Testing:
This patch ran in our collectors for several months.
TODO: Investigate if unit tests could/should be added
Documentation:
The existing telemetry is not documented, let me know if I should add some documentation for it.