[receiver/kafkareceiver] standardize on topic names for spans, metrics, and logs #30163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwafle
changed the title
crobert-1
reviewed
Dec 22, 2023
crobert-1
approved these changes
Jan 2, 2024
andrzej-stencel
approved these changes
Jan 9, 2024
jwafle
force-pushed
the
feat/standardize-default-topic
branch
from
b50ac2a to
fe1eb81
Compare
|
Hi @MovieStoreGuy! Would you be able to merge? If any more changes are necessary, I'd be happy to make them. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@MovieStoreGuy or @pavolloffay can you take a look as code owners? |
jwafle
force-pushed
the
feat/standardize-default-topic
branch
from
fe1eb81 to
e7d89f4
Compare
MovieStoreGuy
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates the default topics for metrics and logs consumers to be the same as the
kafkaexporterdefault topics for metrics and logs exporters.Link to tracking Issue: #27292
Testing: Added testing in
factory_test.goto test that topics are set correctly for spans, metrics, and logs consumers.Documentation: Updated the comments in
config.goandREADME.mdto match the updates.