[pkg/translator/azure] Allow timestamp to be used instead of time #28805
Conversation
…n alternative to the documented 'time'.
cparkins
changed the title
| JSON numbers are encoded as doubles. | ||
| * Additionally the field timestamp can be used instead of time. |
There was a problem hiding this comment.
| * Additionally the field timestamp can be used instead of time. | |
| * Additionally the field `timestamp` can be used instead of `time`. |
Formatting nit.
Do you want to add the timestamp/timeStamp field to the table above since it's supported now?
Also, would it be helpful to state in the README here that if both are included, time takes precedence over timestamp?
There was a problem hiding this comment.
I added the note as suggested. I was trying to make the least amount of change to the table above to avoid making it confusing. Hopefully what I did makes sense.
| @@ -95,10 +95,11 @@ and the OpenTelemetry attributes. | |||
| | resultSignature (optional) | azure.result.signature (attribute) | | |||
| | resultType (optional) | azure.result.type (attribute) | | |||
| | tenantId (required, tenant logs) | azure.tenant.id (attribute) | | |||
| | time (required) | time_unix_nano (field) | | |||
| | time or timeStamp (required) | time_unix_nano (time takes precedence) | | |||
There was a problem hiding this comment.
It would make more sense to me to have the time takes precedence comment in the same column as time or timeStamp, but this is just personal preference, this should be generally understandable.
|
@atoulme @djaglowski would it be possible to get some reviews on this one? We are waiting eagerly on this one, would be very appreciated 😊 |
|
@bogdandrutu Possible to get this one into next release? 🙏🏻 |
…en-telemetry#28805) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Allow the attribute 'timestamp' to be used as an alternative to the documented 'time'. **Link to tracking Issue:** <Issue number if applicable> [open-telemetry#28806] **Testing:** <Describe what testing was performed and which tests were added.> Using the example from Azure I created a unit test. **Documentation:** <Describe the documentation added.> Note added to Azure Event Hub Receiver.
Description:
Allow the attribute 'timestamp' to be used as an alternative to the documented 'time'.
Link to tracking Issue:
[#28806]
Testing:
Using the example from Azure I created a unit test.
Documentation:
Note added to Azure Event Hub Receiver.