[tiny][pkg/stanza] Name Windows event provider on error msg #27286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Oct 2, 2023
djaglowski
added a commit
that referenced
this pull request
Oct 2, 2023
djaglowski
pushed a commit
that referenced
this pull request
Oct 3, 2023
**Description:** Restore #27286 (see PR #27397) and add missing test update. **Link to tracking Issue:** N/A **Testing:** Ran test locally. **Documentation:** N/A cc @djaglowski @songy23
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…emetry#27286) Name Windows event provider on error msg
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…pen-telemetry#27397) Reverts open-telemetry#27286 This is failing tests on main. I apologize for not enabling Windows tests on the PR. @pjanotti, would you mind updating tests and resubmitting?
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
open-telemetry#27399) **Description:** Restore open-telemetry#27286 (see PR open-telemetry#27397) and add missing test update. **Link to tracking Issue:** N/A **Testing:** Ran test locally. **Documentation:** N/A cc @djaglowski @songy23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
While reading #21491 the first thing that I wanted to know was the name of the affected provider. Unfortunately, the error message doesn't include that information. This PR changes that.
Link to tracking Issue:
Collateral to #21491
Testing:
N/A
Documentation:
N/A