Warn instead of failing when renaming metrics using metric_relabel_configs #25888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
allow_renaming
branch
from
c879dd7 to
c4e3b5a
Compare
crobert-1
approved these changes
Aug 24, 2023
crobert-1
reviewed
Aug 24, 2023
dashpole
force-pushed
the
allow_renaming
branch
from
d8c8985 to
188a0cc
Compare
dashpole
force-pushed
the
allow_renaming
branch
from
188a0cc to
98d48c3
Compare
dashpole
force-pushed
the
allow_renaming
branch
from
98d48c3 to
9be0ae4
Compare
crobert-1
approved these changes
Sep 8, 2023
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Hey folks, any traction on this? I was hoping to use this in the context of a prometheus receiver not exporting to prometheus |
|
Pinging @open-telemetry/collector-contrib-approvers for review |
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
…nfigs (open-telemetry#25888) **Description:** Fixes open-telemetry#5001 When that issue was filed, we dropped unknown-typed metrics. Now that we convert them to gauges, users may want to use metric_relabel_configs to rename metrics, even if they lose metadata. In the future, we have other enhancements planned to better-support unknown-typed metrics. Change the error to a warning. It is still likely not a best practice to use relabel configs for this purpose, but for users copy-pasting prometheus configs, it is best not to fail if we can help it.
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…nfigs (open-telemetry#25888) **Description:** Fixes open-telemetry#5001 When that issue was filed, we dropped unknown-typed metrics. Now that we convert them to gauges, users may want to use metric_relabel_configs to rename metrics, even if they lose metadata. In the future, we have other enhancements planned to better-support unknown-typed metrics. Change the error to a warning. It is still likely not a best practice to use relabel configs for this purpose, but for users copy-pasting prometheus configs, it is best not to fail if we can help it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #5001
When that issue was filed, we dropped unknown-typed metrics. Now that we convert them to gauges, users may want to use metric_relabel_configs to rename metrics, even if they lose metadata. In the future, we have other enhancements planned to better-support unknown-typed metrics.
Change the error to a warning. It is still likely not a best practice to use relabel configs for this purpose, but for users copy-pasting prometheus configs, it is best not to fail if we can help it.