Switch k8s metrics (container, pod, node, namespace) to use pdata. #23423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
move_container_pod_namespace_node_to_pdata
branch
from
f912820
to
33269fe
Compare
atoulme
force-pushed
the
move_container_pod_namespace_node_to_pdata
branch
from
33269fe
to
b2038d5
Compare
atoulme
force-pushed
the
move_container_pod_namespace_node_to_pdata
branch
from
b2038d5
to
21f2e3d
Compare
atoulme
force-pushed
the
move_container_pod_namespace_node_to_pdata
branch
from
e279ee2
to
3d71e9a
Compare
dmitryax
reviewed
Jun 16, 2023
Comment on lines
+38
to
+39
| mb.RecordK8sContainerCPURequestDataPoint(ts, float64(c.Resources.Requests.Cpu().MilliValue())/1000.0) | ||
| mb.RecordK8sContainerCPULimitDataPoint(ts, float64(c.Resources.Limits.Cpu().MilliValue())/1000.0) |
There was a problem hiding this comment.
We miss k8s.container.memory_request and k8s.container.memory_limit now
| case corev1.ResourceMemory: | ||
| mb.RecordK8sNodeAllocatableMemoryDataPoint(ts, quantity.Value()) | ||
| case corev1.ResourceEphemeralStorage: | ||
| mb.RecordK8sNodeAllocatableEphemeralStorageDataPoint(ts, quantity.Value()) |
|
Maybe better split them as before? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Switch k8s metrics (container, pod, node, namespace) to use pdata.