-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][pkg/stanza/adapter] Add end-to-end benchmark #21929
[chore][pkg/stanza/adapter] Add end-to-end benchmark #21929
Conversation
2063a23
to
ea35894
Compare
ea35894
to
ed585cf
Compare
I've run the benchmarks with a variety of configurations. The following seem to represent the bounds between which I've seen the most benefit from tuning the variables.
w/r/t #21889 and #21184, my takeaway from this benchmark is that both the batch size and number of workers have a meaningful impact on performance. The flush interval does not, but is a necessary consequence of batching. That said, before we add new parameters, I'd like to briefly pursue a couple of potential opportunities for simplifying the codebase, and then confirm the benchmark still indicates the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ed585cf
to
ff0afcd
Compare
Follows #21928
Add an end-to-end benchmark where logs pass through the entire package, rather than only through the converter.
consumertest.LogsSink
.This is part of an effort to evaluate whether or not we are actually benefiting from non-configurable options such as workers and batching logic. (See #21889 and #21184)