[pkg/ottl] Add support for setting maps in Values#16352
Merged
Conversation
TylerHelmuth
requested review from
bogdandrutu and
evan-bradley
as code owners
evan-bradley
approved these changes
Nov 18, 2022
evan-bradley
left a comment
evan-bradley
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. One thing I think we should also support are maps with typed values, but that doesn't block this PR.
TylerHelmuth
added
the
ready to merge
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2022
Adds support for setting maps in Values. The primary impact is the ability for contexts to set maps as attribute values.
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
Adds support for setting maps in Values. The primary impact is the ability for contexts to set maps as attribute values.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds support for setting maps in Values. The primary impact is the ability for contexts to set maps as attribute values.
Link to tracking Issue:
Closes #16337
Testing:
Added unit tests