-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure Monitor Exporter] Add support to SpanEvents of type Exception #16333
Conversation
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
I'm not sure if I have to update the changelog with this change, I'd say yes, but I prefer to wait before doing it |
Pinging @pcwiese as code owner |
I was just polishing up a PR for mapping span events (including the Exceptions). If we go with this PR as a start, you need to do that piece also. Do you want to take that on? |
Depending on how much work you have already done xD I mean, if you need some weeks for having it ready, we can wait, if you need some months, we need these features :) |
I mean, if you tell me the destination for events which aren't exceptions, I can generate the telemetry items and return them as part of the slice I added for exceptions, sending them to AI with current code |
In fact, as part of this PR I mapped exceptions to AI.Exceptions and others to AI.CustomEvents and I undo the changes to map only Exceptions because I wasn't sure about CustomEvents |
Signed-off-by: Jorge Turrado <[email protected]>
I was actually nearly finished with the PR and was trying to get one out tomorrow. For metrics, I believe someone has a PR out , but I haven't taken a serious look yet. #14916 |
Nice!, I can close this PR in that case. I started because I didn't see any in progress work, and we need this feature to migrating our apps to otel and I hadn't got any answer to the issue I opened (don't worry, I know how complex it to manage OSS projects, these things sometime happen). |
For our use case that Telemetry Item is needed, but I can't see anything in the specification about that, the closest things could be Logger.Events (Events API), but I'd like to know if these events will be added to CustomEvents or they will be more traces |
It decided internally to map span events to the traces table.
customevents table is something different I think and not covered yet. A
snippet from that conversation...
"It sounds like agreement has converged on mapping OTel span events to AI
message telemetry (landing in the "traces" kusto table).
And in the future it looks like OTel will introduce "Real User Monitoring"
events open-telemetry/oteps#169
<open-telemetry/oteps#169>, which would map to AI
event telemetry (landing in the "customEvents" kusto table).
I'm planning to go ahead and update the Java exporter mapping accordingly
(currently it is mapping OTel span events to event telemetry).
…On Wed, Nov 16, 2022 at 3:28 PM Jorge Turrado Ferrero < ***@***.***> wrote:
For our use case that Telemetry Item is needed, but I can't see anything
in the specification about that, the closes things could be Logger.Events
(Events API), but I'd like to know if these events will be added to
CustomEvents or they will be more traces
—
Reply to this email directly, view it on GitHub
<#16333 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEBE56V7746EJCPE4IEUDK3WIVU2NANCNFSM6AAAAAASCRXCMQ>
.
You are receiving this because you were mentioned.Message ID:
<open-telemetry/opentelemetry-collector-contrib/pull/16333/c1317815708@
github.com>
|
Thanks for the clarification. |
Description:
Even the specification defines how to treat exceptions, the azure monitor exporter doesn't implement the mapping between SpanEvents with name
exception
. To be able to use this exporter in our applications (and I guess that we are not the only with this requirement), we need to properly map the exceptions to the expected application insights table.This PR adds support to it, processing the SpanEvents and generate the proper envelopes for events with event name
exception
Link to tracking Issue: #16260
Testing: Following the already existing tests, I created a test to check that we don't create new envelops in there is any event attached to the span without the proper name and another test checking that in case of having the proper information, the envelope is generated with the correct information. I have also tested this on my on infrastructure to check that it works, but I can't reflect that in the PR (I could attach a picture, but it doesn't make sense IMO)
Documentation: I only added a note explaining that exception events are mapped to Application Insights Exceptions