Skip to content

[chore] Update collector core dependency#16317

Merged
codeboten merged 1 commit into
open-telemetry:mainfrom
dmitryax:updatecore
Nov 15, 2022
Merged

[chore] Update collector core dependency#16317
codeboten merged 1 commit into
open-telemetry:mainfrom
dmitryax:updatecore

Conversation

@dmitryax

@dmitryax dmitryax commented Nov 15, 2022

Copy link
Copy Markdown
Member

Besides the dependency version upgrade the PR includes the following changes to remove usage of deprecated APIs:

  1. In adoption to deprecation of [Span|Trace]ID.HexString method [pdata] Deprecate HexString func on SpanID and TraceID opentelemetry-collector#6530, this change includes migration to [Span|Trace]ID implementing fmt.Stringer interface for display purposes. The change touches the following files:
  • exporter/awsxrayexporter/internal/translator/segment.go
  • processor/groupbytraceprocessor/processor.go
  • processor/servicegraphprocessor/processor.go
  • processor/tailsamplingprocessor/processor_test.go
  • receiver/awsxrayreceiver/internal/translator/translator_test.go
  • testbed/datasenders/syslog.go
  • testbed/testbed/validator.go
  1. Adopt to service.State enum values renames Change service.State enum values to follow standard name opentelemetry-collector#6492 in:
  • receiver/prometheusreceiver/internal/staleness_end_to_end_test.go
  • testbed/testbed/in_process_collector.go

@codeboten codeboten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 make[2]: Entering directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/pulsarreceiver'
Error: internal/staleness_end_to_end_test.go:195:8: SA1019: service.Running is deprecated: [v0.65.0] use StateRunning. (staticcheck)
		case service.Running, service.Closed, service.Closing:
		     ^

@dmitryax

Copy link
Copy Markdown
Member Author

@codeboten just pushed a code update and updated the description :)

1. In adoption to deprecation of [Span|Trace]ID.HexString method, this change includes migration to [Span|Trace]ID implementing fmt.Stringer interface for display purposes.
2. Adopt to service.State enum values renames
@codeboten codeboten merged commit e1889aa into open-telemetry:main Nov 15, 2022
@dmitryax dmitryax deleted the updatecore branch November 15, 2022 22:21
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants