[chore] Update collector core dependency#16317
Merged
Merged
Conversation
bogdandrutu
approved these changes
Nov 15, 2022
codeboten
reviewed
Nov 15, 2022
codeboten
left a comment
Contributor
There was a problem hiding this comment.
make[2]: Entering directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/pulsarreceiver'
Error: internal/staleness_end_to_end_test.go:195:8: SA1019: service.Running is deprecated: [v0.65.0] use StateRunning. (staticcheck)
case service.Running, service.Closed, service.Closing:
^
Member
Author
|
@codeboten just pushed a code update and updated the description :) |
codeboten
approved these changes
Nov 15, 2022
1. In adoption to deprecation of [Span|Trace]ID.HexString method, this change includes migration to [Span|Trace]ID implementing fmt.Stringer interface for display purposes. 2. Adopt to service.State enum values renames
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides the dependency version upgrade the PR includes the following changes to remove usage of deprecated APIs: