[chore] Don't use deprecated [Span|Trace]ID.HexString method#16301
Merged
dmitryax merged 1 commit intoNov 15, 2022
Conversation
dmitryax
requested review from
Aneurysm9,
TylerHelmuth,
bogdandrutu,
jpkrohling and
mx-psi
as code owners
github-actions
Bot
added
exporter/alibabacloudlogservice
dmitryax
force-pushed
the
replace-usages-of-hexstring
branch
2 times, most recently
from
3c8b528 to
1fc4900
Compare
github-actions
Bot
added
processor/routing
dmitryax
force-pushed
the
replace-usages-of-hexstring
branch
from
1fc4900 to
f511925
Compare
bogdandrutu
approved these changes
Nov 15, 2022
bogdandrutu
left a comment
bogdandrutu
left a comment
Member
There was a problem hiding this comment.
We should create issues to every component and assign to owners to decide if empty string is expected for their encoding or "000000000000000...0000" is the expected value, and update their code to not use the new helper.
dmitryax
force-pushed
the
replace-usages-of-hexstring
branch
from
f511925 to
5e17c7f
Compare
The methods were deprecated since there is no establish convention on how to decode empty trace or span IDs at this point. The current method behavior is preserved in functions added in internal/coreinternal/traceutil. This commit updates all the usages of HexString where the result is used as identifier to the new internal methods.
dmitryax
force-pushed
the
replace-usages-of-hexstring
branch
from
5e17c7f to
0bf06be
Compare
mx-psi
reviewed
Nov 15, 2022
| Exceptions: []awsxray.Exception{ | ||
| { | ||
| ID: aws.String(hexID), | ||
| ID: aws.String(hex.EncodeToString(segmentID[:])), |
Member
There was a problem hiding this comment.
Why do we know it's not empty here?
Member
Author
There was a problem hiding this comment.
newSegmentID always generates a not empty span ID
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2022
…lemetry#16301) The methods were deprecated since there is no establish convention on how to decode empty trace or span IDs at this point. The current method behavior is preserved in functions added in internal/coreinternal/traceutil. This commit updates all the usages of HexString where the result is used as identifier to the new internal methods.
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…lemetry#16301) The methods were deprecated since there is no establish convention on how to decode empty trace or span IDs at this point. The current method behavior is preserved in functions added in internal/coreinternal/traceutil. This commit updates all the usages of HexString where the result is used as identifier to the new internal methods.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The methods were deprecated in open-telemetry/opentelemetry-collector#6530. The current method behavior is preserved in new functions added in internal/coreinternal/traceutil. This commit updates all the usages of
HexStringwhere the result is used as an identifier to the new internal methods.Updates open-telemetry/opentelemetry-collector#6514