[chore]: fix port feature gate's description in apachereceiver#16280
Merged
djaglowski merged 2 commits intoNov 15, 2022
Merged
Conversation
andrzej-stencel
approved these changes
Nov 14, 2022
andrzej-stencel
left a comment
andrzej-stencel
left a comment
Member
There was a problem hiding this comment.
🎉
Not sure if such a small change requires a changelog entry?
djaglowski
approved these changes
Nov 14, 2022
djaglowski
left a comment
djaglowski
left a comment
Member
There was a problem hiding this comment.
Agree, the changelog is not needed here. Otherwise looks good.
aboguszewski-sumo
changed the title
Member
Author
|
Changelog removed. |
aboguszewski-sumo
changed the title
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2022
…telemetry#16280) * fix: fix port feature gate's description * remove changelog
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…telemetry#16280) * fix: fix port feature gate's description * remove changelog
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The description of feature gate
receiver.apache.emitPortAsResourceAttributehad incorrect information (introduced by me). It informed aboutapache.server.nameresource attribute instead ofapache.server.port.Link to tracking Issue: #14791