[receiver/rabbitmq] Fix flaky integration test#16240
Merged
codeboten merged 1 commit intoNov 14, 2022
Merged
Conversation
This test fails periodially with a non-zero exit code returned from the setup script. The likely cause is that the wait strategy was not robust enough, in that the rabbitmqadmin command was not ready before associated commands were run. This fix incorporates the setup script into a custom wait strategy, which allows the script to be rerun until it succeeds.
evan-bradley
approved these changes
Nov 11, 2022
evan-bradley
left a comment
evan-bradley
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Thanks for fixing this.
codeboten
approved these changes
Nov 14, 2022
mdelapenya
added a commit
to mdelapenya/opentelemetry-collector-contrib
that referenced
this pull request
Nov 15, 2022
* main: [chore] dependabot updates Tue Nov 15 00:17:56 UTC 2022 (open-telemetry#16300) [receiver/rabbitmq] Fix flaky integration test (open-telemetry#16240) [Docker Stats Receiver] Add @jamesmoessis as code owner (open-telemetry#16253) [receiver/mongodbatlas] Alerts poll mode check hostname and port (open-telemetry#16286) [chore] update jaeger dep (open-telemetry#16287) [pkg/stanza] Fix issue where specifying a non-existent storage extension caused panic during shutdown. (open-telemetry#16213) [pkg/ottl] Rename ottllogs to ottllog (open-telemetry#16242) Register featuregate, otherwise does not work (open-telemetry#16269) [receiver/elasticsearch]: add fielddata memory size metrics on index level (open-telemetry#14922) [chore] remove what looks to be debugging code from instanaexporter (open-telemetry#16258)
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2022
This test fails periodially with a non-zero exit code returned from the setup script. The likely cause is that the wait strategy was not robust enough, in that the rabbitmqadmin command was not ready before associated commands were run. This fix incorporates the setup script into a custom wait strategy, which allows the script to be rerun until it succeeds.
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
This test fails periodially with a non-zero exit code returned from the setup script. The likely cause is that the wait strategy was not robust enough, in that the rabbitmqadmin command was not ready before associated commands were run. This fix incorporates the setup script into a custom wait strategy, which allows the script to be rerun until it succeeds.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test fails periodially with a non-zero exit code returned from the setup script. The likely cause is that the wait strategy was not robust enough, in that the rabbitmqadmin command was not ready before associated commands were run.
This fix incorporates the setup script into a custom wait strategy, which allows the script to be rerun until it succeeds.
Resolves #14708