[examples/demo] fix demo could not stat up

[JaredTan95]

Signed-off-by: Jared Tan jian.tan@daocloud.io

Description:

fix #16090

Link to tracking Issue:

Testing:

Documentation:

[JaredTan95]

/skip-changelog

[PassionateDeveloper86]

This sadly doesnt fix the bug on my machine (W11, Docker for Windows), same error when I apply your fix manuelly and rebuild the images

[JaredTan95]

This sadly doesnt fix the bug on my machine (W11, Docker for Windows), same error when I apply your fix manuelly and rebuild the images

It doesn't make sense, I tested in my local dev. I will test it again.

[JaredTan95]

@PassionateDeveloper86 I update dockerfile, could you test it with apple M1 ?

[saurabhdes]

Thankyou @JaredTan95 for the PR. I will check it on my Mac M1 Pro later today and post the result here.

[saurabhdes]

@JaredTan95 , I checked out your fork and branch - good news is it's now working on my Mac M1 Pro, but with below caveats:

1. 1st time i ran docker compose up -d , demo-server started successfully but demo-client failed with error 2022/11/08 17:53:35 Failed to create the collector trace exporter: context deadline exceeded
2. The i ran docker compose up -d again, after that demo-client started sucessfully.

I can reproduce this consistently, by running

1. docker-compose down
2. docker-compose up -d , notice error in demo-client
3. docker-compose up -d, now demo-client runs successfully

Attached some screenshots - the 1st and 2nd show the error, the 3rd and 4th show the resolution after running Step 3 above.

[JaredTan95]

yes, it's another issue,because of otel collector not ready before demo-client start up.

[saurabhdes]

Yes, i agree it's a separate issue. I found a workaround which is to have restart: always in demo-client's docker compose specification, but we may need some time to figure out a better alternative.

[JaredTan95]

Yes, i agree it's a separate issue. I found a workaround which is to have restart: always in demo-client's docker compose specification, but we may need some time to figure out a better alternative.

restart: always make sense. i will update it.

another solution, add otel healthcheck for demo-client in docker-compose.

[saurabhdes]

thanks @JaredTan95 , checked out latest commit on my M1 Pro and all containers are starting correctly. PR looks good from my side .

[JaredTan95]

thanks @JaredTan95 , checked out latest commit on my M1 Pro and all containers are starting correctly. PR looks good from my side .

thx for your testing. 👍

[JaredTan95]

@mx-psi pls help review this :-P