[processor/servicegraph] Fixes the number of bucket counts

[JaredTan95]

Description:

fix #16000

Link to tracking Issue:

Testing:

Documentation:

[JaredTan95]

@mapno hi, do you have time to help review this?

[mapno]

Nice catch

[JaredTan95]

@jpkrohling hi, do you have time to help review this PR?

[MovieStoreGuy]

One thing I wanted to double check, looking at the associated issue, I can see that the the problem happens at line 331 of processor.go (I forgot to grab a link to the line).

Are these buckets always going to have a fixed size of N+1 values?

It does concern me that there is no check to see if the index is in the bounds of the slice, since this theoretically happen again.

[JaredTan95]

One thing I wanted to double check, looking at the associated issue, I can see that the the problem happens at line 331 of processor.go (I forgot to grab a link to the line).

Are these buckets always going to have a fixed size of N+1 values?

It does concern me that there is no check to see if the index is in the bounds of the slice, since this theoretically happen again.

Fully tested, there are no out-of-scope errors indeed, it might be a check policy in

opentelemetry-collector-contrib/processor/servicegraphprocessor/processor.go

Line 422 in d397c98

dpDuration.BucketCounts().FromRaw(p.reqDurationSecondsBucketCounts[key])

, I guess

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[panpan0000]

Any experter can follow up with this change?

[JaredTan95]

@MovieStoreGuy hi, I added some UT to test it, do you have time to help review this? We are eager to use the latest patches as soon as possible :-P

[jpkrohling]

Looks like the CI failed:

Error: processor_test.go:315:29: tc.reqDurationBounds undefined (type struct{caseStr string; duration float64} has no field or method reqDurationBounds) (typecheck)
			p.reqDurationBounds = tc.reqDurationBounds

[JaredTan95]

Looks like the CI failed:

Error: processor_test.go:315:29: tc.reqDurationBounds undefined (type struct{caseStr string; duration float64} has no field or method reqDurationBounds) (typecheck)
			p.reqDurationBounds = tc.reqDurationBounds

resolved.

[JaredTan95]

@jpkrohling hi, pls help review this. :-P