Skip to content

[Receiver/redisreceiver] Support redis.cpu.time with more label values for Redis versions >= 6.0#14943

Merged
codeboten merged 1 commit into
open-telemetry:mainfrom
singku:main
Nov 15, 2022
Merged

[Receiver/redisreceiver] Support redis.cpu.time with more label values for Redis versions >= 6.0#14943
codeboten merged 1 commit into
open-telemetry:mainfrom
singku:main

Conversation

@singku

@singku singku commented Oct 13, 2022

Copy link
Copy Markdown
Contributor

Description:

Redis with version >= 6.0 introduced two more cpu usage time items:

  • used_cpu_sys_main_thread
  • used_cpu_user_main_thread

Link to tracking Issue:

Testing:
Existing test.

Documentation:

@singku singku requested a review from a team October 13, 2022 22:00
@singku singku requested a review from dmitryax as a code owner October 13, 2022 22:00
@singku singku force-pushed the main branch 2 times, most recently from 237663a to b73ddea Compare October 13, 2022 22:27
Comment thread receiver/redisreceiver/metric_functions.go Outdated
Comment thread receiver/redisreceiver/metric_functions.go Outdated
Comment thread receiver/redisreceiver/documentation.md Outdated
Comment thread receiver/redisreceiver/metadata.yaml Outdated
@jpkrohling

Copy link
Copy Markdown
Member

CI seems to be failing.

Add more state values to redis.cpu.time metrics to support sys_main_thread and user_main_thread cpu usage time.
@singku

singku commented Oct 20, 2022

Copy link
Copy Markdown
Contributor Author

Re-synced with head and CI is passing

@singku

singku commented Oct 24, 2022

Copy link
Copy Markdown
Contributor Author

@jpkrohling FYI

@singku

singku commented Oct 26, 2022

Copy link
Copy Markdown
Contributor Author

Any update?

@singku

singku commented Oct 31, 2022

Copy link
Copy Markdown
Contributor Author

Gental ping @jpkrohling @codeboten @dmitryax

@singku

singku commented Nov 7, 2022

Copy link
Copy Markdown
Contributor Author

last ping

@codeboten codeboten merged commit b6e5fbe into open-telemetry:main Nov 15, 2022
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-collector-contrib that referenced this pull request Nov 21, 2022
…s for Redis versions >= 6.0 (open-telemetry#14943)

Update Redis Receiver to Support CPU Metrics After 6.0

Add more state values to redis.cpu.time metrics to support sys_main_thread and user_main_thread cpu usage time.
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
…s for Redis versions >= 6.0 (open-telemetry#14943)

Update Redis Receiver to Support CPU Metrics After 6.0

Add more state values to redis.cpu.time metrics to support sys_main_thread and user_main_thread cpu usage time.
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
@bjandras bjandras mentioned this pull request Sep 6, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants