[receiver/dockerstats] Combine and simplify multiple blockio metrics by making "operation" an attribute#13445
Merged
jpkrohling merged 8 commits intoSep 6, 2022
Conversation
Contributor
Author
|
@rmfitzpatrick @MovieStoreGuy FYI + please review if you have time 😄 |
MovieStoreGuy
approved these changes
Aug 22, 2022
MovieStoreGuy
left a comment
Contributor
There was a problem hiding this comment.
This change makes sense to me.
Contributor
Author
|
Hi @rmfitzpatrick @djaglowski just bumping this PR |
rmfitzpatrick
approved these changes
Aug 31, 2022
Contributor
|
These changes seem good to me, and I imagine similar updates can be made to the |
Contributor
Author
|
@jpkrohling @djaglowski I have codeowner approval and one other approval. Can I get this reviewed/merged please 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Instead of having several blockio metrics with the operation appended on the name as
.read, .write, .sync, .async, .total, .discardwe pull the operation out into an attribute. This simplifies the code a lot:This is a breaking change for anyone using the featuregated v2 implementation, which is not enabled by default yet. To my knowledge, no one is using the new v2 implementation yet.
Link to tracking Issue: #9794
Testing:
The tests logic remain the same, but the expected metrics are updates to align with the changes.
Documentation:
Documentation automatically updated by
go generate.