[receiver/dockerstats] Featuregate for new mdatagen implementation + semantic convention alignment#12743
Merged
dmitryax merged 9 commits intoAug 1, 2022
Conversation
…t with legacy scrape now that the metrics are different
MovieStoreGuy
left a comment
MovieStoreGuy
left a comment
Contributor
There was a problem hiding this comment.
Just a few comments on it but it is straight forward enough.
I do need to revisit what is the recommended time to give users for breaking changes.
Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>
Contributor
Author
|
Looks like there's an unrelated windows test failing the build |
Contributor
Author
|
@dmitryax is there anything left to do to get this PR merged? Perhaps a codeowner review from @rmfitzpatrick might help? |
rmfitzpatrick
approved these changes
Aug 1, 2022
dmitryax
approved these changes
Aug 1, 2022
Member
|
@jamesmoessis LGTM. But it's better to submit separate PRs for unrelated even small changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR:
Link to tracking Issue: #9794
Testing:
Units are changed in
expected_metrics.jsonfiles, as well as descriptions added. The legacy scrape implementation is now not tested in comparison to the new one, since they are have different units and descriptions. They have been proven equivalent by the last PR, and now they will start to diverge as we make enhancements to the new implementation.Documentation: Documented the feature gate in the README.