Skip to content

Renaming crash reporter event #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LikeTheSalad wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

Renaming crash reporter event #1691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ation/crash/src/main/java/io/opentelemetry/android/instrumentation/crash/CrashReporter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ internal class CrashReporter(
val eventBuilder =
logger.logRecordBuilder()
eventBuilder
.setEventName("device.crash")
.setEventName("app.crash")
.setAllAttributes(attributesBuilder.build())
.emit()
}
Expand Down
10 changes: 5 additions & 5 deletions ...rc/test/java/io/opentelemetry/android/instrumentation/crash/CrashReportIntegrationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ import io.opentelemetry.sdk.logs.data.LogRecordData
import io.opentelemetry.sdk.testing.junit4.OpenTelemetryRule
import io.opentelemetry.semconv.ExceptionAttributes
import io.opentelemetry.semconv.incubating.ThreadIncubatingAttributes
import java.io.PrintWriter
import java.util.concurrent.CountDownLatch
import java.util.concurrent.Executors
import java.util.concurrent.TimeUnit
import org.junit.Assert.assertEquals
import org.junit.Assert.assertNotNull
import org.junit.Assert.assertTrue
import org.junit.Before
import org.junit.Test
import java.io.PrintWriter
import java.util.concurrent.CountDownLatch
import java.util.concurrent.Executors
import java.util.concurrent.TimeUnit

internal class CrashReportIntegrationTest {
private lateinit var rule: OpenTelemetryRule
Expand Down Expand Up @@ -188,7 +188,7 @@ internal class CrashReportIntegrationTest {
expectedExcType: String,
expectedExcMessage: String? = null,
) {
assertEquals("device.crash", eventName)
assertEquals("app.crash", eventName)
assertEquals(Severity.UNDEFINED_SEVERITY_NUMBER, severity)

val attrs = attributes.asMap().mapKeys { it.key.key }
Expand Down
Loading