Skip to content

Do not run OnReadMessageError when a connection closes normally#488

Merged
tigrannajaryan merged 1 commit intoopen-telemetry:mainfrom
michel-laterman:bug-fix/no-read-err-callback-on-normal-close
Jan 9, 2026
Merged

Do not run OnReadMessageError when a connection closes normally#488
tigrannajaryan merged 1 commit intoopen-telemetry:mainfrom
michel-laterman:bug-fix/no-read-err-callback-on-normal-close

Conversation

@michel-laterman
Copy link
Copy Markdown
Contributor

Fix connection OnReadMessageError callback invocation to not run when the server receives a normal exit control message.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.72%. Comparing base (d508718) to head (2bf609e).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #488   +/-   ##
=======================================
  Coverage   81.71%   81.72%           
=======================================
  Files          27       27           
  Lines        2122     2123    +1     
=======================================
+ Hits         1734     1735    +1     
  Misses        263      263           
  Partials      125      125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tigrannajaryan tigrannajaryan merged commit a7af82b into open-telemetry:main Jan 9, 2026
11 checks passed
@michel-laterman michel-laterman deleted the bug-fix/no-read-err-callback-on-normal-close branch January 9, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants