Clean up docs, add syntax.md and semconv.schema.json #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Oberon00
changed the title
Oberon00
commented
Jul 15, 2021
| @@ -0,0 +1,235 @@ | |||
| # Semantic Convention YAML Language | |||
There was a problem hiding this comment.
As stated in the PR description, this file is copied from https://github.com/open-telemetry/opentelemetry-specification/blob/main/semantic_conventions/syntax.md so that we can have any changes that affect the input format of the semantic convention generator in one PR in one repo, instead of split over spec and build-tools.
arminru
reviewed
Jul 15, 2021
Co-authored-by: Armin Ruech <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
Very useful for example for auto-completion in VS Code. Co-authored-by: Giovanni Liva <[email protected]> Co-authored-by: Christian Neumüller <[email protected]> Co-authored-by: Gernot Reisinger <[email protected]>
Co-authored-by: Armin Ruech <[email protected]>
Co-authored-by: Armin Ruech <[email protected]>
mariojonke
approved these changes
Jul 19, 2021
thisthat
approved these changes
Jul 20, 2021
|
@open-telemetry/specs-approvers Please review if this seems to be the right direction to go (see PR description). |
carlosalberto
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up I recommend removing the copy of
syntax.mdfrom https://github.com/open-telemetry/opentelemetry-specification/blob/main/semantic_conventions/syntax.md and adapt the link in https://github.com/open-telemetry/opentelemetry-specification/blob/main/semantic_conventions/README.md.Logically, I think syntax.md needs to be here in the build-tools repository so we can update it in the same PR where we update something about the tool's input parsing (e.g. when adding new features).