-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds required stability property to enum members #267
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
force-pushed
the
enum-member-stability
branch
from
February 21, 2024 02:01
9e0f4d8
to
64262bc
Compare
trask
approved these changes
Feb 21, 2024
Merged
5 tasks
alanwest
approved these changes
Feb 21, 2024
joaopgrassi
approved these changes
Feb 22, 2024
semantic-conventions/src/tests/data/markdown/stability/labels_expected.md
Outdated
Show resolved
Hide resolved
semantic-conventions/src/tests/data/yaml/errors/stability/experimental_attr_stable_member.yaml
Show resolved
Hide resolved
lmolkova
force-pushed
the
enum-member-stability
branch
2 times, most recently
from
February 22, 2024 19:42
61793f6
to
27a4590
Compare
lmolkova
changed the title
Adds stability property to enum members
Adds required stability property to enum members
Feb 23, 2024
lmolkova
force-pushed
the
enum-member-stability
branch
4 times, most recently
from
February 26, 2024 22:58
8fa208a
to
18ad1d7
Compare
lmolkova
force-pushed
the
enum-member-stability
branch
from
February 27, 2024 23:05
18ad1d7
to
549c2a9
Compare
2 tasks
arminru
approved these changes
Mar 6, 2024
This was referenced Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See open-telemetry/semantic-conventions#670 (comment) for the context
As a part of DB and messaging semconv stability, we want to stabilize corresponding
*.system
attribute.However it would affect only a subset of corresponding member values.
We need a mechanism that would allow to declare which of the constants are stable.