-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically run release tests on liboqs release candidates #345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this proposal: Smart. Conceptually LGTM/I get the logic -- but the changes in release-test.sh appear to prohibit the use of the script standalone (wreaking havoc on the local github setup). But then again, this CI logic should eliminate the need/desire to run the script locally, so I think I'd be OK with the if/when you mark it Ready for Review -- assuming we also activate the matching upstream trigger-logic so this is always done during release.
I've renamed the script |
Upstream PR to trigger this: open-quantum-safe/liboqs#1654. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice logic -- particularly the local execution wrapper: Thanks!
Perfect. Should the "...-tracker mechanism" turn out to work well, we may also change wording in https://github.com/open-quantum-safe/liboqs/blob/main/.github/pull_request_template.md (demanding such branches to be present in relevant subprojects). |
…safe#345) * Add CI job for triggering downstream tests, e.g., during releases * Add wrapper around CI script for local use * Generalize workflow so that the provider ref can be specified Signed-off-by: Felipe Ventura <[email protected]>
…safe#345) * Add CI job for triggering downstream tests, e.g., during releases * Add wrapper around CI script for local use * Generalize workflow so that the provider ref can be specified Signed-off-by: Felipe Ventura <[email protected]>
…safe#345) * Add CI job for triggering downstream tests, e.g., during releases * Add wrapper around CI script for local use * Generalize workflow so that the provider ref can be specified Signed-off-by: Felipe Ventura <[email protected]>
…safe#345) * Add CI job for triggering downstream tests, e.g., during releases * Add wrapper around CI script for local use * Generalize workflow so that the provider ref can be specified Signed-off-by: Felipe Ventura <[email protected]>
…safe#345) * Add CI job for triggering downstream tests, e.g., during releases * Add wrapper around CI script for local use * Generalize workflow so that the provider ref can be specified Signed-off-by: Felipe Ventura <[email protected]>
This PR proposes a release test workflow which can be triggered by
repository_dispatch
events. For example, with a corresponding PR inliboqs
, we could trigger these workflows to run automatically on release candidates.For a proof-of-concept, see https://github.com/SWilson4/cicd-playground-upstream and https://github.com/SWilson4/cicd-playground-downstream.