Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFCI] Move Keccak rhotates tables to rodata #1739

Merged
merged 1 commit into from
Apr 2, 2024
Merged

[NFCI] Move Keccak rhotates tables to rodata #1739

merged 1 commit into from
Apr 2, 2024

Conversation

aaupov
Copy link
Contributor

@aaupov aaupov commented Mar 27, 2024 •
edited
Loading

rhotates tables are placed to .text section which confuses tools such as
BOLT. Move them to rodata to unbreak and avoid polluting icache/iTLB
with data.

  1. Update patch file using the steps in scripts/copy_from_xkcp/README
  2. Apply the updated patch with scripts/copy_from_xkcp/package.sh

Sync with XKCP upstream: XKCP/XKCP#137
Similar fix in OpenSSL: openssl/openssl#21440
Redo of #1508

Signed-off-by: Amir Ayupov [email protected]

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

@aaupov aaupov requested a review from dstebila as a code owner March 27, 2024 02:11
@aaupov
[NFCI] Move Keccak rhotates tables to rodata
1d85eed 
rhotates tables are placed to .text section which confuses tools such as
BOLT. Move them to rodata to unbreak and avoid polluting icache/iTLB
with data.

1. Update patch file using the steps in scripts/copy_from_xkcp/README
2. Apply the updated patch with scripts/copy_from_xkcp/package.sh

Sync with XKCP upstream: XKCP/XKCP#137
Similar fix in OpenSSL: openssl/openssl#21440
Redo of open-quantum-safe#1508

Signed-off-by: Amir Ayupov <[email protected]>
baentsch
baentsch approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (also in copy_from_xkcp patch to persist: Good). Thanks for the contribution!

@aaupov
Copy link
Contributor Author

aaupov commented Apr 1, 2024

@dstebila, mind taking a look? Thanks!

@dstebila dstebila merged commit 3dd478e into open-quantum-safe:main Apr 2, 2024
43 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstebila dstebila dstebila approved these changes

@baentsch baentsch baentsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaupov @dstebila @baentsch