Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MacOS CI tests to GitHub Actions; add M1 CI tests #1709

Merged
merged 8 commits into from
Feb 27, 2024

Conversation

SWilson4
Copy link
Member

This PR moves our macOS CI tests from CircleCI to GitHub Actions. It also takes advantage of the new M1 runner. I believe this promotes macOS on aarch64 to a "Tier 1" platform.

Fixes #1630.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

Copy link
Member

@Martyrshot Martyrshot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! Just a quick question about macos x86. :)

.github/workflows/unix.yml Show resolved Hide resolved
@baentsch
Copy link
Member

Nice PR! Just a quick question about macos x86. :)

Well, what about (Apple on) PowerPC? :-)

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much! LGTM

@Martyrshot
Copy link
Member

Nice PR! Just a quick question about macos x86. :)

Well, what about (Apple on) PowerPC? :-)

X86_64 is still supported by all MacOS releases. PowerPC is not. :)

@SWilson4 SWilson4 merged commit c119f20 into main Feb 27, 2024
76 checks passed
@SWilson4 SWilson4 deleted the sw-macos-ghactions branch February 27, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CI for macOS on Apple Silicon
3 participants