Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross compilation and test in CI #1696

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Conversation

SWilson4
Copy link
Member

The recent addition of the oqs-internal library broke cross compilation for Windows due to differing object visibility defaults for Linux and Windows.

This is pending our Focal container being updated to install gcc-mingw-w64.

I also took the opportunity to update our checkout workflows to v4, which will make the GitHub Actions deprecation warnings go away.

Fixes #1693.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates and new cross-compile CI job! LGTM -- if CI now triggered passes.

@SWilson4 SWilson4 force-pushed the sw-cross-compile-linkage-bug branch from 0ff4c7b to 33fe571 Compare February 13, 2024 14:17
@SWilson4 SWilson4 marked this pull request as ready for review February 13, 2024 15:17
@SWilson4 SWilson4 requested a review from dstebila as a code owner February 13, 2024 15:17
@SWilson4
Copy link
Member Author

The container has been updated and the tests all pass, including the new ones for cross-compilation.

@SWilson4 SWilson4 merged commit ac164b4 into main Feb 13, 2024
61 checks passed
@SWilson4 SWilson4 deleted the sw-cross-compile-linkage-bug branch February 13, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crosscompilation from linux to windows fails
3 participants