Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Falcon updates from PQClean #1523

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Pull Falcon updates from PQClean #1523

merged 1 commit into from
Aug 10, 2023

Conversation

dstebila
Copy link
Member

@dstebila dstebila commented Aug 9, 2023

PQClean/PQClean@c3abebf

Fixes #1488.

  • [No] Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • [No] Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in oqs-provider, OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

@dstebila dstebila added this to the 0.9.0 milestone Aug 9, 2023
@dstebila dstebila requested a review from SWilson4 August 9, 2023 17:07
@dstebila dstebila requested a review from baentsch as a code owner August 9, 2023 17:07
@dstebila dstebila self-assigned this Aug 9, 2023
@dstebila dstebila requested a review from bhess as a code owner August 9, 2023 17:07
Copy link
Member

@SWilson4 SWilson4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

docs/algorithms/kem/kyber.yml Show resolved Hide resolved
docs/algorithms/sig/dilithium.yml Show resolved Hide resolved
@dstebila
Copy link
Member Author

I'm not sure what aspect of the code generation script caused the line breaks -- can you take a quick look @SWilson4?

@SWilson4
Copy link
Member

I'm not sure what aspect of the code generation script caused the line breaks -- can you take a quick look @SWilson4?

It turns out that it's expected behaviour of the yaml.dump function, which breaks lines at some default width unless an optional width key is provided:

def store_yaml(filename, contents, encoding='utf-8'):
with open(filename, mode='w', encoding=encoding) as fh:
yaml.dump(contents, fh, sort_keys=False, allow_unicode=True)

Apparently the result is still valid YAML, so I don't think we need to worry about it.

@dstebila dstebila merged commit d14825a into main Aug 10, 2023
@dstebila dstebila deleted the ds-pqclean-20230809 branch August 10, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.8.0rc1 MSVC 32-bit builds fail on Falcon with AVX
2 participants