Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dilithium 3.1 update #900

Closed
bhess opened this issue Feb 9, 2021 · 6 comments
Closed

Dilithium 3.1 update #900

bhess opened this issue Feb 9, 2021 · 6 comments
Milestone

Comments

@bhess
Copy link
Member

bhess commented Feb 9, 2021

Dilithium was recently updated to version 3.1. The new implementation needs to be pulled and the KAT need to be updated.

@baentsch
Copy link
Member

baentsch commented Feb 9, 2021

As it's still some effort (particularly when changing names) to push algorithm updates through all downstream projects, what about doing only one PR to resolve this and #896 and #899? Further, does this upgrade entail an (openssl) OID update, too?

@bhess
Copy link
Member Author

bhess commented Feb 9, 2021

Agreed, will do a common PR with #896 and #899 (suggest priority for #889). There isn't a name change this time. I will check if it is safe to dedicate the current OID for Dilithium 3.1 or if it needs an update. The current OIDs were added just recently to oqs-openssl (before a new release), so it could still be fine to do the update without an OID change from an openssl-view. What is your opinion on that?

@baentsch
Copy link
Member

baentsch commented Feb 9, 2021

What is your opinion on that?

Given those OIDs are in the "OQS-public" only since a few days, I don't see much of a problem retaining those ("3.0" ones). Also, as we didn't do a regular release anyone using this already clearly does at his own risk. There'd only be a (minimal) issue to OQS if those OIDs had been in use for longer in other, proprietary/in-house software and persistent artifacts (aka certs) had been created with them and there'd be people expecting interoperability with OQS. You know the maintainer of those OIDs and can determine the answer for this.

What does make me wonder, though, is how likely it is that Dilithium 3.2, 3.3... appears soon, given it was less than a week between 3.0 was integrated and a 3.1 becomes available. Or in other words: Would it be sensible to wait resolving this issue a bit until this code settles?

@bhess
Copy link
Member Author

bhess commented Feb 9, 2021

Given those OIDs are in the "OQS-public" only since a few days, I don't see much of a problem retaining those ("3.0" ones). Also, as we didn't do a regular release anyone using this already clearly does at his own risk. There'd only be a (minimal) issue to OQS if those OIDs had been in use for longer in other, proprietary/in-house software and persistent artifacts (aka certs) had been created with them and there'd be people expecting interoperability with OQS. You know the maintainer of those OIDs and can determine the answer for this.

Thanks, this confirms my thought. I was mainly wondering about the openssl-side and if it is considered a rolling release or bound to a liboqs-release.

What does make me wonder, though, is how likely it is that Dilithium 3.2, 3.3... appears soon, given it was less than a week between 3.0 was integrated and a 3.1 becomes available. Or in other words: Would it be sensible to wait resolving this issue a bit until this code settles?

Not likely, the short time between integration and 3.1 was more a coincidence. But I would suggest to resolve this issue only after the upstream-code has been tagged.

@baentsch
Copy link
Member

baentsch commented Feb 9, 2021

or bound to a liboqs-release

OIDs would rather be bound to an OQS-OpenSSL release -- which in turn is bound to a liboqs release. Thus, no-one should rely on "bleeding edge" -- but you never know :)

But I would suggest to resolve this issue only after the upstream-code has been tagged.

Good approach. Thanks.

bhess added a commit to bhess/liboqs that referenced this issue Feb 9, 2021
@dstebila dstebila added this to the 0.5.0 RC1 milestone Feb 17, 2021
@baentsch
Copy link
Member

Closed with #923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants