Remove Apache How To #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to not part of license and not required in license file.
|
Can one of the admins verify this patch? |
ghost
self-assigned this
|
(and this makes me realize we need to have a CONTIRBUTING file or something in the repo) Could you please add a linux-kernel style Signed-off-By: line to your commit? |
|
Closing due to inactivity. If you'd like this merged, please resubmit with Signed-off-by line and preferably by sending patch to the mailing list: [email protected] |
ghost
closed this
ghost
pushed a commit
that referenced
this pull request
Sep 2, 2016
This ends up being harmless bug due to memory layout.
$ ./pflash -F ~/op-build/output/images/firestone.pnor -i
==31829==ERROR: AddressSanitizer: global-buffer-overflow on address 0x00000062f0
80 at pc 0x410226 bp 0x7ffedba9c950 sp 0x7ffedba9c948
WRITE of size 8 at 0x00000062f080 thread T0
#0 0x410225 in file_get_info (/home/stewart/skiboot/external/pflash/pflash+0
x410225)
#1 0x40d832 in blocklevel_get_info (/home/stewart/skiboot/external/pflash/pf
lash+0x40d832)
#2 0x401f0c in main (/home/stewart/skiboot/external/pflash/pflash+0x401f0c)
#3 0x7fc77439ab44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21
b44)
#4 0x403884 (/home/stewart/skiboot/external/pflash/pflash+0x403884)
Signed-off-by: Stewart Smith <[email protected]>
ghost
pushed a commit
to stewartsmith/skiboot
that referenced
this pull request
Aug 23, 2017
…nt', which requires 8 byte alignment
UBSan caught this:
hdata/test/../iohub.c:83:2: runtime error: load of misaligned address 0x7f1dc7b0210a for type 'long unsigned int', which requires 8 byte alignment
0x7f1dc7b0210a: note: pointer points here
31 4c 58 08 31 00 04 01 00 30 00 42 50 46 02 00 00 78 00 00 00 00 00 00 00 00 00 00 00 00 00 00
^
#0 0x41470a in io_get_lx_info hdata/test/../iohub.c:83
open-power#1 0x41759f in io_add_p8_cec_vpd hdata/test/../iohub.c:450
open-power#2 0x417d35 in io_parse_fru hdata/test/../iohub.c:538
open-power#3 0x41812a in io_parse hdata/test/../iohub.c:600
open-power#4 0x425aa2 in parse_hdat hdata/test/../spira.c:1337
open-power#5 0x43d9f8 in main hdata/test/hdata_to_dt.c:358
open-power#6 0x7f1dcb868509 in __libc_start_main (/lib64/libc.so.6+0x20509)
open-power#7 0x4019e9 in _start (/home/stewart/skiboot/hdata/test/hdata_to_dt+0x4019e9)
Signed-off-by: Stewart Smith <[email protected]>
ghost
pushed a commit
to stewartsmith/skiboot
that referenced
this pull request
Aug 24, 2017
…nt', which requires 8 byte alignment
UBSan caught this:
hdata/test/../iohub.c:83:2: runtime error: load of misaligned address 0x7f1dc7b0210a for type 'long unsigned int', which requires 8 byte alignment
0x7f1dc7b0210a: note: pointer points here
31 4c 58 08 31 00 04 01 00 30 00 42 50 46 02 00 00 78 00 00 00 00 00 00 00 00 00 00 00 00 00 00
^
#0 0x41470a in io_get_lx_info hdata/test/../iohub.c:83
open-power#1 0x41759f in io_add_p8_cec_vpd hdata/test/../iohub.c:450
open-power#2 0x417d35 in io_parse_fru hdata/test/../iohub.c:538
open-power#3 0x41812a in io_parse hdata/test/../iohub.c:600
open-power#4 0x425aa2 in parse_hdat hdata/test/../spira.c:1337
open-power#5 0x43d9f8 in main hdata/test/hdata_to_dt.c:358
open-power#6 0x7f1dcb868509 in __libc_start_main (/lib64/libc.so.6+0x20509)
open-power#7 0x4019e9 in _start (/home/stewart/skiboot/hdata/test/hdata_to_dt+0x4019e9)
Signed-off-by: Stewart Smith <[email protected]>
ghost
pushed a commit
to stewartsmith/skiboot
that referenced
this pull request
Aug 24, 2017
…nt', which requires 8 byte alignment
UBSan caught this:
hdata/test/../iohub.c:83:2: runtime error: load of misaligned address 0x7f1dc7b0210a for type 'long unsigned int', which requires 8 byte alignment
0x7f1dc7b0210a: note: pointer points here
31 4c 58 08 31 00 04 01 00 30 00 42 50 46 02 00 00 78 00 00 00 00 00 00 00 00 00 00 00 00 00 00
^
#0 0x41470a in io_get_lx_info hdata/test/../iohub.c:83
open-power#1 0x41759f in io_add_p8_cec_vpd hdata/test/../iohub.c:450
open-power#2 0x417d35 in io_parse_fru hdata/test/../iohub.c:538
open-power#3 0x41812a in io_parse hdata/test/../iohub.c:600
open-power#4 0x425aa2 in parse_hdat hdata/test/../spira.c:1337
open-power#5 0x43d9f8 in main hdata/test/hdata_to_dt.c:358
open-power#6 0x7f1dcb868509 in __libc_start_main (/lib64/libc.so.6+0x20509)
open-power#7 0x4019e9 in _start (/home/stewart/skiboot/hdata/test/hdata_to_dt+0x4019e9)
Signed-off-by: Stewart Smith <[email protected]>
ghost
mentioned this pull request
amboar
added a commit
to amboar/skiboot
that referenced
this pull request
Oct 9, 2019
Rearrange the internal implementation of strdup and its inclusion in
run-mem_region_reservations to avoid invoking the internal
implementation in the wrong contexts:
==9810==ERROR: AddressSanitizer: heap-use-after-free on address 0x629000000218 at pc 0x00000052eb1a bp 0x7ffc31aebe70 sp 0x7ffc31aebe68
READ of size 8 at 0x629000000218 thread T0
#0 0x52eb19 in list_check_node /home/andrew/src/open-power/skiboot/core/test/../../ccan/list/list.c:28:10
open-power#1 0x52eb88 in list_check /home/andrew/src/open-power/skiboot/core/test/../../ccan/list/list.c:40:7
open-power#2 0x4f9a74 in __mem_alloc /home/andrew/src/open-power/skiboot/core/test/../mem_region.c:427:2
open-power#3 0x4f8c14 in mem_alloc /home/andrew/src/open-power/skiboot/core/test/../mem_region.c:488:6
open-power#4 0x5138a0 in __memalign /home/andrew/src/open-power/skiboot/core/test/../malloc.c:21:6
open-power#5 0x50d2cb in __malloc /home/andrew/src/open-power/skiboot/core/test/../malloc.c:29:9
open-power#6 0x513f4d in strdup /home/andrew/src/open-power/skiboot/core/test/../../libc/string/strdup.c:23:8
open-power#7 0x52ee1a in llvm_gcda_start_file (/home/andrew/src/open-power/skiboot/core/test/run-mem_region_reservations-gcov+0x52ee1a)
open-power#8 0x529422 in __llvm_gcov_writeout (/home/andrew/src/open-power/skiboot/core/test/run-mem_region_reservations-gcov+0x529422)
open-power#9 0x530419 in llvm_writeout_files (/home/andrew/src/open-power/skiboot/core/test/run-mem_region_reservations-gcov+0x530419)
open-power#10 0x7f191cf2e2ab in __run_exit_handlers /build/glibc-KRRWSm/glibc-2.29/stdlib/exit.c:108:8
open-power#11 0x7f191cf2e3d9 in exit /build/glibc-KRRWSm/glibc-2.29/stdlib/exit.c:139:3
open-power#12 0x7f191cf0db71 in __libc_start_main /build/glibc-KRRWSm/glibc-2.29/csu/../csu/libc-start.c:342:3
open-power#13 0x41b3d9 in _start (/home/andrew/src/open-power/skiboot/core/test/run-mem_region_reservations-gcov+0x41b3d9)
0x629000000218 is located 24 bytes inside of 16384-byte region [0x629000000200,0x629000004200)
freed by thread T0 here:
#0 0x4c6a52 in __interceptor_free /build/llvm-toolchain-8-F3l7P1/llvm-toolchain-8-8/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:124:3
open-power#1 0x526186 in real_free /home/andrew/src/open-power/skiboot/core/test/run-mem_region_reservations.c:22:9
open-power#2 0x52380c in main /home/andrew/src/open-power/skiboot/core/test/run-mem_region_reservations.c:225:2
open-power#3 0x7f191cf0db6a in __libc_start_main /build/glibc-KRRWSm/glibc-2.29/csu/../csu/libc-start.c:308:16
previously allocated by thread T0 here:
#0 0x4c6dd3 in malloc /build/llvm-toolchain-8-F3l7P1/llvm-toolchain-8-8/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:146:3
open-power#1 0x523896 in real_malloc /home/andrew/src/open-power/skiboot/core/test/run-mem_region_reservations.c:17:9
open-power#2 0x523321 in main /home/andrew/src/open-power/skiboot/core/test/run-mem_region_reservations.c:185:29
open-power#3 0x7f191cf0db6a in __libc_start_main /build/glibc-KRRWSm/glibc-2.29/csu/../csu/libc-start.c:308:16
Signed-off-by: Andrew Jeffery <[email protected]>
amboar
added a commit
to amboar/skiboot
that referenced
this pull request
Oct 10, 2019
Rearrange the internal implementation of strdup and its inclusion in
run-mem_region_reservations to avoid invoking the internal
implementation in the wrong contexts:
==9810==ERROR: AddressSanitizer: heap-use-after-free on address 0x629000000218 at pc 0x00000052eb1a bp 0x7ffc31aebe70 sp 0x7ffc31aebe68
READ of size 8 at 0x629000000218 thread T0
#0 0x52eb19 in list_check_node /home/andrew/src/open-power/skiboot/core/test/../../ccan/list/list.c:28:10
open-power#1 0x52eb88 in list_check /home/andrew/src/open-power/skiboot/core/test/../../ccan/list/list.c:40:7
open-power#2 0x4f9a74 in __mem_alloc /home/andrew/src/open-power/skiboot/core/test/../mem_region.c:427:2
open-power#3 0x4f8c14 in mem_alloc /home/andrew/src/open-power/skiboot/core/test/../mem_region.c:488:6
open-power#4 0x5138a0 in __memalign /home/andrew/src/open-power/skiboot/core/test/../malloc.c:21:6
open-power#5 0x50d2cb in __malloc /home/andrew/src/open-power/skiboot/core/test/../malloc.c:29:9
open-power#6 0x513f4d in strdup /home/andrew/src/open-power/skiboot/core/test/../../libc/string/strdup.c:23:8
open-power#7 0x52ee1a in llvm_gcda_start_file (/home/andrew/src/open-power/skiboot/core/test/run-mem_region_reservations-gcov+0x52ee1a)
open-power#8 0x529422 in __llvm_gcov_writeout (/home/andrew/src/open-power/skiboot/core/test/run-mem_region_reservations-gcov+0x529422)
open-power#9 0x530419 in llvm_writeout_files (/home/andrew/src/open-power/skiboot/core/test/run-mem_region_reservations-gcov+0x530419)
open-power#10 0x7f191cf2e2ab in __run_exit_handlers /build/glibc-KRRWSm/glibc-2.29/stdlib/exit.c:108:8
open-power#11 0x7f191cf2e3d9 in exit /build/glibc-KRRWSm/glibc-2.29/stdlib/exit.c:139:3
open-power#12 0x7f191cf0db71 in __libc_start_main /build/glibc-KRRWSm/glibc-2.29/csu/../csu/libc-start.c:342:3
open-power#13 0x41b3d9 in _start (/home/andrew/src/open-power/skiboot/core/test/run-mem_region_reservations-gcov+0x41b3d9)
0x629000000218 is located 24 bytes inside of 16384-byte region [0x629000000200,0x629000004200)
freed by thread T0 here:
#0 0x4c6a52 in __interceptor_free /build/llvm-toolchain-8-F3l7P1/llvm-toolchain-8-8/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:124:3
open-power#1 0x526186 in real_free /home/andrew/src/open-power/skiboot/core/test/run-mem_region_reservations.c:22:9
open-power#2 0x52380c in main /home/andrew/src/open-power/skiboot/core/test/run-mem_region_reservations.c:225:2
open-power#3 0x7f191cf0db6a in __libc_start_main /build/glibc-KRRWSm/glibc-2.29/csu/../csu/libc-start.c:308:16
previously allocated by thread T0 here:
#0 0x4c6dd3 in malloc /build/llvm-toolchain-8-F3l7P1/llvm-toolchain-8-8/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:146:3
open-power#1 0x523896 in real_malloc /home/andrew/src/open-power/skiboot/core/test/run-mem_region_reservations.c:17:9
open-power#2 0x523321 in main /home/andrew/src/open-power/skiboot/core/test/run-mem_region_reservations.c:185:29
open-power#3 0x7f191cf0db6a in __libc_start_main /build/glibc-KRRWSm/glibc-2.29/csu/../csu/libc-start.c:308:16
Signed-off-by: Andrew Jeffery <[email protected]>
ruscur
pushed a commit
to ruscur/skiboot
that referenced
this pull request
Feb 28, 2020
Here is a proposal to collect OPAL call statistics, counts and duration, and track areas we could possibly improve. With a small Linux driver to dump the stats in debugfs, here is what we get on a P9 after boot: OPAL_CONSOLE_WRITE : #22318 0/0/47 OPAL_RTC_READ : open-power#9 0/4/15 OPAL_READ_NVRAM : #3468 0/0/6 OPAL_HANDLE_INTERRUPT : #4724 0/57/10026 OPAL_POLL_EVENTS : #508 2/141/10033 OPAL_PCI_CONFIG_READ_BYTE : #3623 0/0/4 OPAL_PCI_CONFIG_READ_HALF_WORD : #5579 0/0/8 OPAL_PCI_CONFIG_READ_WORD : #6156 0/0/7 OPAL_PCI_CONFIG_WRITE_BYTE : open-power#2 0/0/0 OPAL_PCI_CONFIG_WRITE_HALF_WORD : #1282 0/0/1 OPAL_PCI_CONFIG_WRITE_WORD : #1335 0/0/1 OPAL_PCI_EEH_FREEZE_STATUS : #11123 0/0/2 OPAL_CONSOLE_WRITE_BUFFER_SPACE : #139088 0/0/11 OPAL_PCI_EEH_FREEZE_CLEAR : open-power#148 1/2/8 OPAL_PCI_PHB_MMIO_ENABLE : open-power#22 0/0/0 OPAL_PCI_SET_PHB_MEM_WINDOW : open-power#22 0/0/1 OPAL_PCI_MAP_PE_MMIO_WINDOW : open-power#56 0/0/0 OPAL_PCI_SET_PE : open-power#44 279/284/293 OPAL_PCI_SET_PELTV : open-power#66 0/0/0 OPAL_PCI_SET_XIVE_PE : #1123 0/0/1 OPAL_GET_MSI_64 : #1120 0/0/0 OPAL_START_CPU : open-power#238 8/21/35 OPAL_QUERY_CPU_STATUS : #357 0/11/69 OPAL_PCI_MAP_PE_DMA_WINDOW : open-power#16 0/0/1 OPAL_PCI_MAP_PE_DMA_WINDOW_REAL : open-power#16 0/0/1 OPAL_PCI_RESET : open-power#35 0/471/851 OPAL62 : open-power#6 0/10/46 OPAL_XSCOM_READ : open-power#26 0/0/2 OPAL_XSCOM_WRITE : open-power#8 0/0/1 OPAL_REINIT_CPUS : open-power#4 348/8247/11061 OPAL_CHECK_TOKEN : #134112 0/0/0 OPAL_GET_MSG : open-power#30 0/0/1 OPAL87 : open-power#1 0/0/0 OPAL_PCI_SET_PHB_CAPI_MODE : open-power#2 0/60/121 OPAL_SLW_SET_REG : #1080 3/3/13 OPAL_IPMI_SEND : open-power#53 0/5/11 OPAL_IPMI_RECV : open-power#53 0/0/2 OPAL_I2C_REQUEST : open-power#20 6/10/19 OPAL_FLASH_READ : open-power#10 19/10452/58305 OPAL_PRD_MSG : open-power#1 0/3/3 OPAL_CONSOLE_FLUSH : #134079 0/0/12 OPAL_PCI_GET_PRESENCE_STATE : open-power#7 1/1/3 OPAL_PCI_GET_POWER_STATE : open-power#9 0/0/0 OPAL_PCI_TCE_KILL : open-power#20 1/8/133 OPAL_NMMU_SET_PTCR : open-power#3 253/255/257 OPAL_XIVE_RESET : open-power#3 0/114709/115403 OPAL_XIVE_GET_IRQ_INFO : #1427 0/0/6 OPAL_XIVE_SET_IRQ_CONFIG : #1113 0/125/2810 OPAL_XIVE_GET_QUEUE_INFO : open-power#240 0/0/2 OPAL_XIVE_SET_QUEUE_INFO : #360 0/60/1216 OPAL_XIVE_ALLOCATE_VP_BLOCK : open-power#2 0/59/60 OPAL_XIVE_GET_VP_INFO : open-power#240 0/0/0 OPAL_XIVE_SET_VP_INFO : #360 0/298/3080 OPAL_XIVE_ALLOCATE_IRQ : open-power#240 0/0/3 OPAL140 : open-power#119 0/253/1109 OPAL_IMC_COUNTERS_INIT : open-power#60 9/10/20 OPAL_IMC_COUNTERS_STOP : open-power#36 0/0/2 OPAL_PCI_GET_PBCQ_TUNNEL_BAR : open-power#1 2/2/2 OPAL_PCI_SET_PBCQ_TUNNEL_BAR : open-power#1 1/1/1 OPAL_NX_COPROC_INIT : open-power#2 3/4/5 Signed-off-by: Cédric Le Goater <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to not part of license and not required in license file.