POZ : revert avoid double memory allocation for ffdc data #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert change done to avoid double memory allocation for ffdc
data.
Earlier test was done with single proc which worked as expected
but with multiple proc and multiple fork processes trying to
read the ffdc data it is causing double free error and core dump.
Tested:
root@p10bmc:/tmp# busctl tree xyz.openbmc_project.Dump.Manager
`- /xyz
`- /xyz/openbmc_project
`- /xyz/openbmc_project/dump
|- /xyz/openbmc_project/dump/hostboot
| `- /xyz/openbmc_project/dump/hostboot/entry
| |- /xyz/openbmc_project/dump/hostboot/entry/20000001
| |- /xyz/openbmc_project/dump/hostboot/entry/20000002
| |- /xyz/openbmc_project/dump/hostboot/entry/20000003
Signed-off-by: Marri Devender Rao <[email protected]>
Change-Id: If38be58d9938b476ab39f35e69583fda28522cd4
deepakala-k
approved these changes
Apr 18, 2024
Swarnendu-R-C
approved these changes
Apr 18, 2024
dhruvibm
approved these changes
Apr 18, 2024
aravynd
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert change done to avoid double memory allocation for ffdc data.
Earlier test was done with single proc which worked as expected but with multiple proc and multiple fork processes trying to read the ffdc data it is causing double free error and core dump.
Tested:
root@p10bmc:/tmp# busctl tree xyz.openbmc_project.Dump.Manager
- /xyz- /xyz/openbmc_project- /xyz/openbmc_project/dump |- /xyz/openbmc_project/dump/hostboot |- /xyz/openbmc_project/dump/hostboot/entry| |- /xyz/openbmc_project/dump/hostboot/entry/20000001
| |- /xyz/openbmc_project/dump/hostboot/entry/20000002
| |- /xyz/openbmc_project/dump/hostboot/entry/20000003
Change-Id: If38be58d9938b476ab39f35e69583fda28522cd4