Revert class names of pib and fsi targets for odyssey chips #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present class name of odyssey pib and fsi targets are set by appending "ody" to "pib" and "fsi" names to differntiate from ddr4 pib, fsi targets to ddr5 pib and fsi targets. It was done to limit the search for the pib/fsi target of the odyssey chip when looping through all the pib and fsi target for the matching proc and ocmb target. Not much advantage though but done for clarity. The change in class names for ody pib and fsi targets are failing in some of the sbe methods like sbe_set_state which are expecting old pib and fsi class names. Signed-off-by: Marri Devender Rao <[email protected]> Change-Id: Ibe589b73e8561c33d2166af812cd4f25aa59078e
deepakala-k
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present class name of odyssey pib and fsi targets are set by appending "ody" to "pib" and "fsi" names to differntiate from ddr4 pib, fsi targets to ddr5 pib and fsi targets.
It was done to limit the search for the pib/fsi target of the odyssey chip when looping through all the pib and fsi target for the matching proc and ocmb target. Not much advantage though but done for clarity.
The change in class names for ody pib and fsi targets are failing in some of the sbe methods like sbe_set_state which are expecting old pib and fsi class names.
Change-Id: Ibe589b73e8561c33d2166af812cd4f25aa59078e